pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: ci: windows: Stop using DEBUG:FASTLINK 4+ messages / 1 participants [nested] [flat]
* pgsql: ci: windows: Stop using DEBUG:FASTLINK @ 2025-08-13 20:26 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2025-08-13 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: windows: Stop using DEBUG:FASTLINK Currently the pdb file for libpq and some other libraries are named the same for the static and shared libraries. That has been the case for a long time, but recently started failing, after an image update started using a newer ninja version. The issue is not itself caused by ninja, but just made visible, as the newer version optimizes the build order and builds the shared libpq earlier than the static library. Previously both static and shared libraries were built at the same time, which prevented msvc from detecting the issue. When using /DEBUG:FASTLINK pdb files cannot be updated, triggering the error. We were using /DEBUG:FASTLINK due to running out of memory in the past, but that was when using container based CI images, rather than full VMs. This isn't really the correct fix (that'd be to deconflict the pdb file names), but we'd like to get CI to become green again, and a proper fix (in meson) will presumably take longer. Suggested-by: Andres Freund <andres@anarazel.de> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com> Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAN55FZ1RuBhJmPWs3Oi%3D9UoezDfrtO-VaU67db5%2B0_uy19uF%2BA%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3e6059cc70c016d2d15a66d3cabadc4d889c3831 Modified Files -------------- .cirrus.tasks.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: ci: windows: Stop using DEBUG:FASTLINK @ 2025-08-13 20:26 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2025-08-13 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: windows: Stop using DEBUG:FASTLINK Currently the pdb file for libpq and some other libraries are named the same for the static and shared libraries. That has been the case for a long time, but recently started failing, after an image update started using a newer ninja version. The issue is not itself caused by ninja, but just made visible, as the newer version optimizes the build order and builds the shared libpq earlier than the static library. Previously both static and shared libraries were built at the same time, which prevented msvc from detecting the issue. When using /DEBUG:FASTLINK pdb files cannot be updated, triggering the error. We were using /DEBUG:FASTLINK due to running out of memory in the past, but that was when using container based CI images, rather than full VMs. This isn't really the correct fix (that'd be to deconflict the pdb file names), but we'd like to get CI to become green again, and a proper fix (in meson) will presumably take longer. Suggested-by: Andres Freund <andres@anarazel.de> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com> Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAN55FZ1RuBhJmPWs3Oi%3D9UoezDfrtO-VaU67db5%2B0_uy19uF%2BA%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c42f2bdcdf7f3ca765b1dc5ba5753e9f8b545e85 Modified Files -------------- .cirrus.tasks.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: ci: windows: Stop using DEBUG:FASTLINK @ 2025-08-13 20:26 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2025-08-13 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: windows: Stop using DEBUG:FASTLINK Currently the pdb file for libpq and some other libraries are named the same for the static and shared libraries. That has been the case for a long time, but recently started failing, after an image update started using a newer ninja version. The issue is not itself caused by ninja, but just made visible, as the newer version optimizes the build order and builds the shared libpq earlier than the static library. Previously both static and shared libraries were built at the same time, which prevented msvc from detecting the issue. When using /DEBUG:FASTLINK pdb files cannot be updated, triggering the error. We were using /DEBUG:FASTLINK due to running out of memory in the past, but that was when using container based CI images, rather than full VMs. This isn't really the correct fix (that'd be to deconflict the pdb file names), but we'd like to get CI to become green again, and a proper fix (in meson) will presumably take longer. Suggested-by: Andres Freund <andres@anarazel.de> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com> Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAN55FZ1RuBhJmPWs3Oi%3D9UoezDfrtO-VaU67db5%2B0_uy19uF%2BA%40mail.gmail.com Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2de22b1ead3cb6b506e0b4a808d1b28786338080 Modified Files -------------- .cirrus.tasks.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: ci: windows: Stop using DEBUG:FASTLINK @ 2025-08-13 20:26 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 4+ messages in thread From: Andres Freund @ 2025-08-13 20:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: windows: Stop using DEBUG:FASTLINK Currently the pdb file for libpq and some other libraries are named the same for the static and shared libraries. That has been the case for a long time, but recently started failing, after an image update started using a newer ninja version. The issue is not itself caused by ninja, but just made visible, as the newer version optimizes the build order and builds the shared libpq earlier than the static library. Previously both static and shared libraries were built at the same time, which prevented msvc from detecting the issue. When using /DEBUG:FASTLINK pdb files cannot be updated, triggering the error. We were using /DEBUG:FASTLINK due to running out of memory in the past, but that was when using container based CI images, rather than full VMs. This isn't really the correct fix (that'd be to deconflict the pdb file names), but we'd like to get CI to become green again, and a proper fix (in meson) will presumably take longer. Suggested-by: Andres Freund <andres@anarazel.de> Author: Nazir Bilal Yavuz <byavuz81@gmail.com> Reviewed-by: Jacob Champion <jacob.champion@enterprisedb.com> Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAN55FZ1RuBhJmPWs3Oi%3D9UoezDfrtO-VaU67db5%2B0_uy19uF%2BA%40mail.gmail.com Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/66f8765c5331a7a27eafb1d498a12ac04bfbdab2 Modified Files -------------- .cirrus.tasks.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-08-13 20:26 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-13 20:26 pgsql: ci: windows: Stop using DEBUG:FASTLINK Andres Freund <andres@anarazel.de> 2025-08-13 20:26 pgsql: ci: windows: Stop using DEBUG:FASTLINK Andres Freund <andres@anarazel.de> 2025-08-13 20:26 pgsql: ci: windows: Stop using DEBUG:FASTLINK Andres Freund <andres@anarazel.de> 2025-08-13 20:26 pgsql: ci: windows: Stop using DEBUG:FASTLINK Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox