pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: vacuumdb: Fix --missing-stats-only with virtual generated column
2+ messages / 1 participants
[nested] [flat]

* pgsql: vacuumdb: Fix --missing-stats-only with virtual generated column
@ 2025-08-22 16:12  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Nathan Bossart @ 2025-08-22 16:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

vacuumdb: Fix --missing-stats-only with virtual generated columns.

Statistics aren't created for virtual generated columns, so
"vacuumdb --missing-stats-only" always chooses to analyze tables
that have them.  To fix, modify vacuumdb's query for retrieving
relations that are missing statistics to exclude those columns.

Oversight in commit edba754f05.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/20250820104226.8ba51e43164cd590b863ce41%40sraoss.co.jp
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b63952a7811319a6525a9ea23afa294a900fa895

Modified Files
--------------
src/bin/scripts/t/100_vacuumdb.pl | 7 ++++---
src/bin/scripts/vacuumdb.c        | 5 +++++
2 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: vacuumdb: Fix --missing-stats-only with virtual generated column
@ 2025-08-22 16:12  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Nathan Bossart @ 2025-08-22 16:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

vacuumdb: Fix --missing-stats-only with virtual generated columns.

Statistics aren't created for virtual generated columns, so
"vacuumdb --missing-stats-only" always chooses to analyze tables
that have them.  To fix, modify vacuumdb's query for retrieving
relations that are missing statistics to exclude those columns.

Oversight in commit edba754f05.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/20250820104226.8ba51e43164cd590b863ce41%40sraoss.co.jp
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8c0c8686374495815c2c970e8652228c5aac4495

Modified Files
--------------
src/bin/scripts/t/100_vacuumdb.pl | 7 ++++---
src/bin/scripts/vacuumdb.c        | 5 +++++
2 files changed, 9 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-08-22 16:12 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-22 16:12 pgsql: vacuumdb: Fix --missing-stats-only with virtual generated column Nathan Bossart <nathan@postgresql.org>
2025-08-22 16:12 pgsql: vacuumdb: Fix --missing-stats-only with virtual generated column Nathan Bossart <nathan@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox