pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi 7+ messages / 1 participants [nested] [flat]
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ad4412480d3ff475a6dfa4a7f449702eff78312d Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c6dca7c3dd65d9f7b436db502338ac233a1c51fd Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/49a09c6c51c0d642e87086bbc7eb748c200d3f43 Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/412d29fd21665d0c4e473efbc9636bd0c16d12a8 Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/090c9c9608b3bf84987ff8403d86a52001989f7d Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/22c6a44f01fd751c2ed229be4003f7c26d671933 Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi @ 2025-08-23 23:47 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 7+ messages in thread From: Noah Misch @ 2025-08-23 23:47 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Rewrite previous commit's test for TestUpgradeXversion compatibility. v17 introduced the MAINTAIN ON TABLES privilege. That changed the applicable "baseacls" reaching buildACLCommands(). That yielded spurious TestUpgradeXversion diffs. Change to use a TYPES privilege. Types have the same one privilege in all supported versions, so they avoid the problem. Per buildfarm. Back-patch to v13, like that commit. Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/fb75e1ef72123476209a4cd5b511f1b9e3c240f2 Modified Files -------------- src/test/regress/expected/privileges.out | 4 ++-- src/test/regress/sql/privileges.sql | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-08-23 23:47 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com> 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com> 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com> 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com> 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com> 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com> 2025-08-23 23:47 pgsql: Rewrite previous commit's test for TestUpgradeXversion compatibi Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox