pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: oauth: Always link with -lm for floor() 2+ messages / 1 participants [nested] [flat]
* pgsql: oauth: Always link with -lm for floor() @ 2025-08-25 16:42 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-08-25 16:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org oauth: Always link with -lm for floor() libpq-oauth uses floor() but did not link against libm. Since libpq itself uses -lm, nothing in the buildfarm has had problems with libpq-oauth yet, and it seems difficult to hit a failure in practice. But commit 1443b6c0e attempted to add an executable based on libpq-oauth, which ran into link-time failures with Clang due to this omission. It seems prudent to fix this for both the module and the executable simultaneously so that no one trips over it in the future. This is a Makefile-only change. The Meson side already pulls in libm, through the os_deps dependency. Discussion: https://postgr.es/m/CAOYmi%2Bn6ORcmV10k%2BdAs%2Bp0b9QJ4bfpk0WuHQaF5ODXxM8Y36A%40mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/52ecd05aeef851b7d3688b0f0a633132c691eb32 Modified Files -------------- src/interfaces/libpq-oauth/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: oauth: Always link with -lm for floor() @ 2025-08-25 16:42 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-08-25 16:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org oauth: Always link with -lm for floor() libpq-oauth uses floor() but did not link against libm. Since libpq itself uses -lm, nothing in the buildfarm has had problems with libpq-oauth yet, and it seems difficult to hit a failure in practice. But commit 1443b6c0e attempted to add an executable based on libpq-oauth, which ran into link-time failures with Clang due to this omission. It seems prudent to fix this for both the module and the executable simultaneously so that no one trips over it in the future. This is a Makefile-only change. The Meson side already pulls in libm, through the os_deps dependency. Discussion: https://postgr.es/m/CAOYmi%2Bn6ORcmV10k%2BdAs%2Bp0b9QJ4bfpk0WuHQaF5ODXxM8Y36A%40mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e76738e597907d7cece10f67b0769b6d0b8d461e Modified Files -------------- src/interfaces/libpq-oauth/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-08-25 16:42 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-25 16:42 pgsql: oauth: Always link with -lm for floor() Jacob Champion <jchampion@postgresql.org> 2025-08-25 16:42 pgsql: oauth: Always link with -lm for floor() Jacob Champion <jchampion@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox