pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: CREATE STATISTICS: improve misleading error message 12+ messages / 2 participants [nested] [flat]
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-08-29 12:44 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 12+ messages in thread From: Álvaro Herrera @ 2025-08-29 12:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message I think the error message for a different condition was inadvertently copied. This problem seems to have been introduced by commit a4d75c86bf15. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 14 Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f225473cbae2cca5e1fde376aa4217a6b3a3f770 Modified Files -------------- src/backend/tcop/utility.c | 3 ++- src/test/regress/expected/stats_ext.out | 26 ++++++++++++++++++++++++++ src/test/regress/sql/stats_ext.sql | 12 ++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-08-29 12:44 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 12+ messages in thread From: Álvaro Herrera @ 2025-08-29 12:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message I think the error message for a different condition was inadvertently copied. This problem seems to have been introduced by commit a4d75c86bf15. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 14 Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3eea4dc2c7cfbd9ef56e34ac25b43ab90fe62c51 Modified Files -------------- src/backend/tcop/utility.c | 3 ++- src/test/regress/expected/stats_ext.out | 26 ++++++++++++++++++++++++++ src/test/regress/sql/stats_ext.sql | 12 ++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-08-29 12:44 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 12+ messages in thread From: Álvaro Herrera @ 2025-08-29 12:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message I think the error message for a different condition was inadvertently copied. This problem seems to have been introduced by commit a4d75c86bf15. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 14 Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e9fb314c7ad89a25eade3c3ed918abab4c532fe2 Modified Files -------------- src/backend/tcop/utility.c | 3 ++- src/test/regress/expected/stats_ext.out | 26 ++++++++++++++++++++++++++ src/test/regress/sql/stats_ext.sql | 12 ++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-08-29 12:44 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 12+ messages in thread From: Álvaro Herrera @ 2025-08-29 12:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message I think the error message for a different condition was inadvertently copied. This problem seems to have been introduced by commit a4d75c86bf15. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 14 Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d84a6c3dad1f867275ed7547c8ae6e120292f94c Modified Files -------------- src/backend/tcop/utility.c | 3 ++- src/test/regress/expected/stats_ext.out | 23 +++++++++++++++++++++++ src/test/regress/sql/stats_ext.sql | 11 +++++++++++ 3 files changed, 36 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-08-29 12:44 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 12+ messages in thread From: Álvaro Herrera @ 2025-08-29 12:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message I think the error message for a different condition was inadvertently copied. This problem seems to have been introduced by commit a4d75c86bf15. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 14 Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f9a7622483c30a45e04a700b6dc90b95ff366fba Modified Files -------------- src/backend/tcop/utility.c | 3 ++- src/test/regress/expected/stats_ext.out | 23 +++++++++++++++++++++++ src/test/regress/sql/stats_ext.sql | 11 +++++++++++ 3 files changed, 36 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-08-29 12:44 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 12+ messages in thread From: Álvaro Herrera @ 2025-08-29 12:44 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message I think the error message for a different condition was inadvertently copied. This problem seems to have been introduced by commit a4d75c86bf15. Author: Álvaro Herrera <alvherre@kurilemu.de> Reported-by: jian he <jian.universality@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Backpatch-through: 14 Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b830f9d67463f770e7c92ac989112c90c1f28dbf Modified Files -------------- src/backend/tcop/utility.c | 3 ++- src/test/regress/expected/stats_ext.out | 23 +++++++++++++++++++++++ src/test/regress/sql/stats_ext.sql | 11 +++++++++++ 3 files changed, 36 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-09-15 10:15 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 12+ messages in thread From: Peter Eisentraut @ 2025-09-15 10:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9ec0b29976b6d73cc08880842caa0db286e46bd4 Modified Files -------------- src/backend/tcop/utility.c | 3 +-- src/test/regress/expected/stats_ext.out | 21 +++++++-------------- 2 files changed, 8 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-09-15 10:15 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 12+ messages in thread From: Peter Eisentraut @ 2025-09-15 10:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/38883916e41c5d3f3367b221b37838c3999227e2 Modified Files -------------- src/backend/tcop/utility.c | 3 +-- src/test/regress/expected/stats_ext.out | 21 +++++++-------------- 2 files changed, 8 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-09-15 10:15 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 12+ messages in thread From: Peter Eisentraut @ 2025-09-15 10:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f9b41f3e1ecd0bd8aab673bc49f4222f683b9c24 Modified Files -------------- src/backend/tcop/utility.c | 3 +-- src/test/regress/expected/stats_ext.out | 21 +++++++-------------- 2 files changed, 8 insertions(+), 16 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-09-15 10:15 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 12+ messages in thread From: Peter Eisentraut @ 2025-09-15 10:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f30c04682cdf3a2fb48c0ab47017b28ef92bbebf Modified Files -------------- src/backend/tcop/utility.c | 3 +-- src/test/regress/expected/stats_ext.out | 18 ++++++------------ 2 files changed, 7 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-09-15 10:15 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 12+ messages in thread From: Peter Eisentraut @ 2025-09-15 10:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4529861cc40886ec57de185fa0fa55f2a0c08c25 Modified Files -------------- src/backend/tcop/utility.c | 3 +-- src/test/regress/expected/stats_ext.out | 18 ++++++------------ 2 files changed, 7 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
* pgsql: CREATE STATISTICS: improve misleading error message @ 2025-09-15 10:15 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 12+ messages in thread From: Peter Eisentraut @ 2025-09-15 10:15 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org CREATE STATISTICS: improve misleading error message The previous change (commit f225473cbae) was still not on target, because it talked about relation kinds, which are not what is being checked here. Provide a more accurate message. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CACJufxEZ48toGH0Em_6vdsT57Y3L8pLF=DZCQ_gCii6=C3MeXw@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cbd3732cbbaa0fa083a12ca2d9df18ff606736da Modified Files -------------- src/backend/tcop/utility.c | 3 +-- src/test/regress/expected/stats_ext.out | 18 ++++++------------ 2 files changed, 7 insertions(+), 14 deletions(-) ^ permalink raw reply [nested|flat] 12+ messages in thread
end of thread, other threads:[~2025-09-15 10:15 UTC | newest] Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-08-29 12:44 pgsql: CREATE STATISTICS: improve misleading error message Álvaro Herrera <alvherre@kurilemu.de> 2025-08-29 12:44 pgsql: CREATE STATISTICS: improve misleading error message Álvaro Herrera <alvherre@kurilemu.de> 2025-08-29 12:44 pgsql: CREATE STATISTICS: improve misleading error message Álvaro Herrera <alvherre@kurilemu.de> 2025-08-29 12:44 pgsql: CREATE STATISTICS: improve misleading error message Álvaro Herrera <alvherre@kurilemu.de> 2025-08-29 12:44 pgsql: CREATE STATISTICS: improve misleading error message Álvaro Herrera <alvherre@kurilemu.de> 2025-08-29 12:44 pgsql: CREATE STATISTICS: improve misleading error message Álvaro Herrera <alvherre@kurilemu.de> 2025-09-15 10:15 pgsql: CREATE STATISTICS: improve misleading error message Peter Eisentraut <peter@eisentraut.org> 2025-09-15 10:15 pgsql: CREATE STATISTICS: improve misleading error message Peter Eisentraut <peter@eisentraut.org> 2025-09-15 10:15 pgsql: CREATE STATISTICS: improve misleading error message Peter Eisentraut <peter@eisentraut.org> 2025-09-15 10:15 pgsql: CREATE STATISTICS: improve misleading error message Peter Eisentraut <peter@eisentraut.org> 2025-09-15 10:15 pgsql: CREATE STATISTICS: improve misleading error message Peter Eisentraut <peter@eisentraut.org> 2025-09-15 10:15 pgsql: CREATE STATISTICS: improve misleading error message Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox