pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix incorrect comment in pgstat_backend.c 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect comment in pgstat_backend.c @ 2025-09-03 23:35 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2025-09-03 23:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect comment in pgstat_backend.c The counters saved from pgWalUsage, used for the difference calculations when flushing the backend WAL stats, are updated when calling pgstat_flush_backend() under PGSTAT_BACKEND_FLUSH_WAL, and not pgstat_report_wal(). The comment updated in this commit referenced the latter, but it is perfectly OK to flush the backend stats independently of the WAL stats. Noticed while looking at this area of the code, introduced by 76def4cdd7c2 as a copy-pasto. Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/09119238a18191dea3deed635a2b2a6ffe904932 Modified Files -------------- src/backend/utils/activity/pgstat_backend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix incorrect comment in pgstat_backend.c @ 2025-09-03 23:35 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2025-09-03 23:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect comment in pgstat_backend.c The counters saved from pgWalUsage, used for the difference calculations when flushing the backend WAL stats, are updated when calling pgstat_flush_backend() under PGSTAT_BACKEND_FLUSH_WAL, and not pgstat_report_wal(). The comment updated in this commit referenced the latter, but it is perfectly OK to flush the backend stats independently of the WAL stats. Noticed while looking at this area of the code, introduced by 76def4cdd7c2 as a copy-pasto. Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c91c61b2417d0c36993deff03f09b1f64c821a1b Modified Files -------------- src/backend/utils/activity/pgstat_backend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-09-03 23:35 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-03 23:35 pgsql: Fix incorrect comment in pgstat_backend.c Michael Paquier <michael@paquier.xyz> 2025-09-03 23:35 pgsql: Fix incorrect comment in pgstat_backend.c Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox