pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. @ 2025-09-12 21:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2025-09-12 21:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversights in pg_event_trigger_dropped_objects() fixes. Commit a0b99fc12 caused pg_event_trigger_dropped_objects() to not fill the object_name field for schemas, which it should have; and caused it to fill the object_name field for default values, which it should not have. In addition, triggers and RLS policies really should behave the same way as we're making column defaults do; that is, they should have is_temporary = true if they belong to a temporary table. Fix those things, and upgrade event_trigger.sql's woefully inadequate test coverage of these secondary output columns. As before, back-patch only to v15. Reported-by: Sergey Shinderuk <s.shinderuk@postgrespro.ru> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/bd7b4651-1c26-4d30-832b-f942fabcb145@postgrespro.ru Backpatch-through: 15 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ef81db9697a082300b452c8dd6824d2d07f5f557 Modified Files -------------- src/backend/commands/event_trigger.c | 87 ++++++++++++- src/test/regress/expected/event_trigger.out | 188 +++++++++++++++++----------- src/test/regress/sql/event_trigger.sql | 55 ++++++-- 3 files changed, 244 insertions(+), 86 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. @ 2025-09-12 21:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2025-09-12 21:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversights in pg_event_trigger_dropped_objects() fixes. Commit a0b99fc12 caused pg_event_trigger_dropped_objects() to not fill the object_name field for schemas, which it should have; and caused it to fill the object_name field for default values, which it should not have. In addition, triggers and RLS policies really should behave the same way as we're making column defaults do; that is, they should have is_temporary = true if they belong to a temporary table. Fix those things, and upgrade event_trigger.sql's woefully inadequate test coverage of these secondary output columns. As before, back-patch only to v15. Reported-by: Sergey Shinderuk <s.shinderuk@postgrespro.ru> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/bd7b4651-1c26-4d30-832b-f942fabcb145@postgrespro.ru Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f6c8e7824c5d3872556d1f717f5a5328e5f3e594 Modified Files -------------- src/backend/commands/event_trigger.c | 88 ++++++++++++- src/test/regress/expected/event_trigger.out | 184 +++++++++++++++++----------- src/test/regress/sql/event_trigger.sql | 55 +++++++-- 3 files changed, 243 insertions(+), 84 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. @ 2025-09-12 21:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2025-09-12 21:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversights in pg_event_trigger_dropped_objects() fixes. Commit a0b99fc12 caused pg_event_trigger_dropped_objects() to not fill the object_name field for schemas, which it should have; and caused it to fill the object_name field for default values, which it should not have. In addition, triggers and RLS policies really should behave the same way as we're making column defaults do; that is, they should have is_temporary = true if they belong to a temporary table. Fix those things, and upgrade event_trigger.sql's woefully inadequate test coverage of these secondary output columns. As before, back-patch only to v15. Reported-by: Sergey Shinderuk <s.shinderuk@postgrespro.ru> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/bd7b4651-1c26-4d30-832b-f942fabcb145@postgrespro.ru Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/f14ea34d6e563374cd71b4e7b91cf8d2f60aabb3 Modified Files -------------- src/backend/commands/event_trigger.c | 87 ++++++++++++- src/test/regress/expected/event_trigger.out | 188 +++++++++++++++++----------- src/test/regress/sql/event_trigger.sql | 55 ++++++-- 3 files changed, 244 insertions(+), 86 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. @ 2025-09-12 21:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2025-09-12 21:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversights in pg_event_trigger_dropped_objects() fixes. Commit a0b99fc12 caused pg_event_trigger_dropped_objects() to not fill the object_name field for schemas, which it should have; and caused it to fill the object_name field for default values, which it should not have. In addition, triggers and RLS policies really should behave the same way as we're making column defaults do; that is, they should have is_temporary = true if they belong to a temporary table. Fix those things, and upgrade event_trigger.sql's woefully inadequate test coverage of these secondary output columns. As before, back-patch only to v15. Reported-by: Sergey Shinderuk <s.shinderuk@postgrespro.ru> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/bd7b4651-1c26-4d30-832b-f942fabcb145@postgrespro.ru Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a220e40d11063cf2e43bdfb5e1ca872fe201f37d Modified Files -------------- src/backend/commands/event_trigger.c | 87 ++++++++++++- src/test/regress/expected/event_trigger.out | 184 +++++++++++++++++----------- src/test/regress/sql/event_trigger.sql | 55 +++++++-- 3 files changed, 242 insertions(+), 84 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. @ 2025-09-12 21:43 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2025-09-12 21:43 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix oversights in pg_event_trigger_dropped_objects() fixes. Commit a0b99fc12 caused pg_event_trigger_dropped_objects() to not fill the object_name field for schemas, which it should have; and caused it to fill the object_name field for default values, which it should not have. In addition, triggers and RLS policies really should behave the same way as we're making column defaults do; that is, they should have is_temporary = true if they belong to a temporary table. Fix those things, and upgrade event_trigger.sql's woefully inadequate test coverage of these secondary output columns. As before, back-patch only to v15. Reported-by: Sergey Shinderuk <s.shinderuk@postgrespro.ru> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/bd7b4651-1c26-4d30-832b-f942fabcb145@postgrespro.ru Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/33e49ee014b07118bcce5490e3586dc605b2d302 Modified Files -------------- src/backend/commands/event_trigger.c | 88 ++++++++++++- src/test/regress/expected/event_trigger.out | 184 +++++++++++++++++----------- src/test/regress/sql/event_trigger.sql | 55 +++++++-- 3 files changed, 243 insertions(+), 84 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-09-12 21:43 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-12 21:43 pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. Tom Lane <tgl@sss.pgh.pa.us> 2025-09-12 21:43 pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. Tom Lane <tgl@sss.pgh.pa.us> 2025-09-12 21:43 pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. Tom Lane <tgl@sss.pgh.pa.us> 2025-09-12 21:43 pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. Tom Lane <tgl@sss.pgh.pa.us> 2025-09-12 21:43 pgsql: Fix oversights in pg_event_trigger_dropped_objects() fixes. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox