pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_restore: Fix comment handling with --no-publications / --no-s 9+ messages / 1 participants [nested] [flat]
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:41 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b54e8dbfe3b17648770a60c1a1bf99479bb766ce Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 44 ++++++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:41 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/77d2b155caf716354a3519233f2cef3369984a65 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 44 ++++++++++++++++++++++++++++++++++++ 2 files changed, 58 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:41 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f7f9c5d6581602d7bc264572753b6b95dc2173a8 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 41 ++++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:41 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/97527a5e68d523048fd80aa1c97c3fe5bf948fb6 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 +++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 45 ++++++++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:42 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c8ed1605056435bd617d661c87d02d64d8dde3ba Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 37 ++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:42 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/db900ec358bd0ffa59b60a906f2ddc5305bc6b8b Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 37 ++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-publications / --no-s @ 2025-09-16 01:42 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 01:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-publications / --no-subscriptions. Previously, pg_restore did not skip comments on publications or subscriptions even when --no-publications or --no-subscriptions was specified. As a result, it could issue COMMENT commands for objects that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on publications and subscriptions are also skipped when the corresponding options are used. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8fbd1f8ea2e14a1ac1d16a7d90d301833c76e273 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 14 ++++++++++++++ src/bin/pg_dump/t/002_pg_dump.pl | 37 ++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-policies. @ 2025-09-16 02:55 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 02:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-policies. Previously, pg_restore did not skip comments on policies even when --no-policies was specified. As a result, it could issue COMMENT commands for policies that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on policies are also skipped when --no-policies is used. Backpatch to v18, where --no-policies was added in pg_restore. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/66dabc06b1b0aaadfd5be640a2e3efbeea0fcaf5 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 7 +++++- src/bin/pg_dump/t/002_pg_dump.pl | 46 ++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: pg_restore: Fix comment handling with --no-policies. @ 2025-09-16 02:56 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 9+ messages in thread From: Fujii Masao @ 2025-09-16 02:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_restore: Fix comment handling with --no-policies. Previously, pg_restore did not skip comments on policies even when --no-policies was specified. As a result, it could issue COMMENT commands for policies that were never created, causing those commands to fail. This commit fixes the issue by ensuring that comments on policies are also skipped when --no-policies is used. Backpatch to v18, where --no-policies was added in pg_restore. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2ddbfede0c615c009bbbb0f8dfcaa848da5d2376 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 7 +++++- src/bin/pg_dump/t/002_pg_dump.pl | 46 ++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2025-09-16 02:56 UTC | newest] Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-16 01:41 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 01:41 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 01:41 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 01:41 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 01:42 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 01:42 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 01:42 pgsql: pg_restore: Fix comment handling with --no-publications / --no-s Fujii Masao <fujii@postgresql.org> 2025-09-16 02:55 pgsql: pg_restore: Fix comment handling with --no-policies. Fujii Masao <fujii@postgresql.org> 2025-09-16 02:56 pgsql: pg_restore: Fix comment handling with --no-policies. Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox