pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve 7+ messages / 1 participants [nested] [flat]
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8e5b92928d2847f556f9fd75edf619935dc87010 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:49 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/176002c5bfa61421497b382e9a4b4f7315dda42d Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:50 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/968141898777a484e6250b912b89289bd47e1340 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:50 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/20b23784fc312e848de4fbca8012eb1733b86795 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:50 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/165b07efe4e28bcd6ab5ca85609694bef982d532 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:50 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/295c0a644af5c32e5310c5523cac0ccec64115e5 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve @ 2025-09-16 07:51 Fujii Masao <fujii@postgresql.org> 0 siblings, 0 replies; 7+ messages in thread From: Fujii Masao @ 2025-09-16 07:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_dump: Fix dumping of security labels on subscriptions and event triggers. Previously, pg_dump incorrectly queried pg_seclabel to retrieve security labels for subscriptions, which are stored in pg_shseclabel as they are global objects. This could result in security labels for subscriptions not being dumped. This commit fixes the issue by updating pg_dump to query the pg_seclabels view, which aggregates entries from both pg_seclabel and pg_shseclabel. While querying pg_shseclabel directly for subscriptions was an alternative, using pg_seclabels is simpler and sufficient. In addition, pg_dump is updated to dump security labels on event triggers, which were previously omitted. Backpatch to all supported versions. Author: Jian He <jian.universality@gmail.com> Co-authored-by: Fujii Masao <masao.fujii@gmail.com> Discussion: https://postgr.es/m/CACJufxHCt00pR9h51AVu6+yPD5J7JQn=7dQXxqacj0XyDhc-fA@mail.gmail.com Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dff7591a7041b4ccbb42806c6492a29d86fece86 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 12 +++++++----- src/bin/pg_dump/pg_dump.c | 7 ++++++- 2 files changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-09-16 07:51 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-16 07:49 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org> 2025-09-16 07:49 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org> 2025-09-16 07:50 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org> 2025-09-16 07:50 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org> 2025-09-16 07:50 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org> 2025-09-16 07:50 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org> 2025-09-16 07:51 pgsql: pg_dump: Fix dumping of security labels on subscriptions and eve Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox