pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Make some use of anonymous unions [reorderbuffer xact_time]
8+ messages / 5 participants
[nested] [flat]

* pgsql: Make some use of anonymous unions [reorderbuffer xact_time]
@ 2025-09-30 10:37  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Peter Eisentraut @ 2025-09-30 10:37 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [reorderbuffer xact_time]

Make some use of anonymous unions, which are allowed as of C11, as
examples and encouragement for future code, and to test compilers.

This commit changes the ReorderBufferTXN struct.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/f00a9968-388e-4f8c-b5ef-5102e962d997%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/57d46dff9b0ba8dc50fb37166373ea7638ecd2b9

Modified Files
--------------
contrib/test_decoding/test_decoding.c           | 12 ++++++------
src/backend/replication/logical/proto.c         | 14 +++++++-------
src/backend/replication/logical/reorderbuffer.c | 14 +++++++-------
src/backend/replication/pgoutput/pgoutput.c     |  2 +-
src/include/replication/reorderbuffer.h         |  2 +-
5 files changed, 22 insertions(+), 22 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Make some use of anonymous unions [pg_locale_t]
@ 2025-09-30 10:37  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Peter Eisentraut @ 2025-09-30 10:37 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [pg_locale_t]

Make some use of anonymous unions, which are allowed as of C11, as
examples and encouragement for future code, and to test compilers.

This commit changes the pg_locale_t type.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/f00a9968-388e-4f8c-b5ef-5102e962d997%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4b7e6c73b0df3384345052616727a25505db5fcb

Modified Files
--------------
src/backend/utils/adt/pg_locale_builtin.c | 20 ++++-----
src/backend/utils/adt/pg_locale_icu.c     | 18 ++++----
src/backend/utils/adt/pg_locale_libc.c    | 70 +++++++++++++++----------------
src/include/utils/pg_locale.h             |  2 +-
4 files changed, 55 insertions(+), 55 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Make some use of anonymous unions [pgcrypto]
@ 2025-09-30 10:37  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 1 reply; 8+ messages in thread

From: Peter Eisentraut @ 2025-09-30 10:37 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [pgcrypto]

Make some use of anonymous unions, which are allowed as of C11, as
examples and encouragement for future code, and to test compilers.

This commit changes some structures in pgcrypto.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/f00a9968-388e-4f8c-b5ef-5102e962d997%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/efcd5199d8cb8e5098f79b38d0c46004e69d1a46

Modified Files
--------------
contrib/pgcrypto/openssl.c | 14 +++++++-------
contrib/pgcrypto/px.h      |  2 +-
src/common/cryptohash.c    | 36 ++++++++++++++++++------------------
3 files changed, 26 insertions(+), 26 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Make some use of anonymous unions [plpython]
@ 2025-09-30 10:37  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Peter Eisentraut @ 2025-09-30 10:37 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [plpython]

Make some use of anonymous unions, which are allowed as of C11, as
examples and encouragement for future code, and to test compilers.

This commit changes some structures in plpython.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/f00a9968-388e-4f8c-b5ef-5102e962d997%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8b7f27fef3e225e0b34f0d9f1a9f20770b72d01c

Modified Files
--------------
src/pl/plpython/plpy_exec.c   |   2 +-
src/pl/plpython/plpy_typeio.c | 134 +++++++++++++++++++++---------------------
src/pl/plpython/plpy_typeio.h |   4 +-
3 files changed, 70 insertions(+), 70 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pgsql: Make some use of anonymous unions [pgcrypto]
@ 2025-09-30 11:15  David Rowley <dgrowleyml@gmail.com>
  parent: Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 8+ messages in thread

From: David Rowley @ 2025-09-30 11:15 UTC (permalink / raw)
  To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, 30 Sept 2025 at 23:37, Peter Eisentraut <peter@eisentraut.org> wrote:
> src/common/cryptohash.c    | 36 ++++++++++++++++++------------------

This seems to be causing some trouble:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sifaka&dt=2025-09-30%2010%3A57%3A42

David





^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Make some use of anonymous unions [DSM registry].
@ 2025-10-03 15:15  Nathan Bossart <nathan@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Nathan Bossart @ 2025-10-03 15:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [DSM registry].

Make some use of anonymous unions, which are allowed as of C11, as
examples and encouragement for future code, and to test compilers.

This commit changes the DSMRegistryEntry struct.

Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/aNKsDg0fJwqhZdXX%40nathan

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/74b41f5a77b8586356d02227c92e7e47380ac228

Modified Files
--------------
src/backend/storage/ipc/dsm_registry.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Make some use of anonymous unions [libpq-oauth]
@ 2025-11-24 20:24  Jacob Champion <jchampion@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Jacob Champion @ 2025-11-24 20:24 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [libpq-oauth]

Make some use of anonymous unions, which are allowed as of C11, as
examples and encouragement for future code, and to test compilers.

This commit changes the json_field struct.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://postgr.es/m/CAOYmi%2BnV25oC5uXFgWodydGrHkfWMDCLUcjbAreM3mNX%3DF2JWw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f1881c7dd32cf5f429f6bd525b5cbacef3bb9c99

Modified Files
--------------
src/interfaces/libpq-oauth/oauth-curl.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Make some use of anonymous unions [reloptions]
@ 2026-01-22 16:07  Álvaro Herrera <alvherre@kurilemu.de>
  0 siblings, 0 replies; 8+ messages in thread

From: Álvaro Herrera @ 2026-01-22 16:07 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make some use of anonymous unions [reloptions]

In the spirit of commit 4b7e6c73b0df and following, which see for more
details; it appears to have been quite an uncontroversial C11 feature to
use and it makes the code nicer to read.

This commit changes the relopt_value struct.

Author: Peter Eisentraut <peter@eisentraut.org>
Author: Álvaro Herrera <alvherre@kurilemu.de>
Note: Yes, this was written twice independently.
Discussion: https://postgr.es/m/202601192106.zcdi3yu2gzti@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/69f98fce5bfb82260c66bdae88b6293146cf79ec

Modified Files
--------------
src/backend/access/common/reloptions.c | 38 +++++++++++++++++-----------------
src/include/access/reloptions.h        |  2 +-
2 files changed, 20 insertions(+), 20 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread


end of thread, other threads:[~2026-01-22 16:07 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-09-30 10:37 pgsql: Make some use of anonymous unions [pg_locale_t] Peter Eisentraut <peter@eisentraut.org>
2025-09-30 10:37 pgsql: Make some use of anonymous unions [reorderbuffer xact_time] Peter Eisentraut <peter@eisentraut.org>
2025-09-30 10:37 pgsql: Make some use of anonymous unions [pgcrypto] Peter Eisentraut <peter@eisentraut.org>
2025-09-30 11:15 ` Re: pgsql: Make some use of anonymous unions [pgcrypto] David Rowley <dgrowleyml@gmail.com>
2025-09-30 10:37 pgsql: Make some use of anonymous unions [plpython] Peter Eisentraut <peter@eisentraut.org>
2025-10-03 15:15 pgsql: Make some use of anonymous unions [DSM registry]. Nathan Bossart <nathan@postgresql.org>
2025-11-24 20:24 pgsql: Make some use of anonymous unions [libpq-oauth] Jacob Champion <jchampion@postgresql.org>
2026-01-22 16:07 pgsql: Make some use of anonymous unions [reloptions] Álvaro Herrera <alvherre@kurilemu.de>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox