pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Adjust new TAP test to work on macOS.
3+ messages / 2 participants
[nested] [flat]
* pgsql: Adjust new TAP test to work on macOS.
@ 2025-10-07 15:47 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2025-10-07 15:47 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Adjust new TAP test to work on macOS.
Seems Apple's version of "wc -l" puts spaces before the number.
(I wonder why the cfbot didn't find this.) While here, make
the failure case log what it got, to aid debugging future issues.
Per buildfarm.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/afd532c3a80c12a9c0f836c5e4fc3cfe6503b91f
Modified Files
--------------
src/bin/psql/t/030_pager.pl | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Adjust new TAP test to work on macOS.
@ 2025-10-07 16:07 Andres Freund <andres@anarazel.de>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Andres Freund @ 2025-10-07 16:07 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On 2025-10-07 15:47:58 +0000, Tom Lane wrote:
> Adjust new TAP test to work on macOS.
>
> Seems Apple's version of "wc -l" puts spaces before the number.
> (I wonder why the cfbot didn't find this.)
[15:04:43.968] 222/352 postgresql:psql / psql/030_pager SKIP 0.11s
I guess we need IO::Pty on macos. But, oddly enouugh, we are installing
p5.34-io-tty, which I thought was the right package. Not sure what's going on.
Greetings,
Andres
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Adjust new TAP test to work on macOS.
@ 2025-10-07 16:13 Tom Lane <tgl@sss.pgh.pa.us>
parent: Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 3+ messages in thread
From: Tom Lane @ 2025-10-07 16:13 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org
Andres Freund <andres@anarazel.de> writes:
> On 2025-10-07 15:47:58 +0000, Tom Lane wrote:
>> (I wonder why the cfbot didn't find this.)
> I guess we need IO::Pty on macos. But, oddly enouugh, we are installing
> p5.34-io-tty, which I thought was the right package. Not sure what's going on.
Nah, I realized what'd happened immediately after pushing:
the cfbot's run just silently skipped that test because the
probe of what "wc -l" produces didn't match what it expected.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-10-07 16:13 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-10-07 15:47 pgsql: Adjust new TAP test to work on macOS. Tom Lane <tgl@sss.pgh.pa.us>
2025-10-07 16:07 ` Andres Freund <andres@anarazel.de>
2025-10-07 16:13 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox