pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Avoid warnings in tests when openssl binary isn't available 4+ messages / 1 participants [nested] [flat]
* pgsql: Avoid warnings in tests when openssl binary isn't available @ 2025-10-17 13:05 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Daniel Gustafsson @ 2025-10-17 13:05 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid warnings in tests when openssl binary isn't available The SSL tests for pg_stat_ssl tries to exactly match the serial from the certificate by extracting it with the openssl binary. If that fails due to the binary not being available, a fallback match is used, but the attempt to execute a missing binary adds a warning to the output which can confuse readers for a failure in the test. Fix by only attempting if the openssl binary was found by autoconf/meson. Backpatch down to v16 where commit c8e4030d1bdd made the test use the OPENSSL variable from autoconf/meson instead of a hard- coded value. Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Christoph Berg <myon@debian.org> Discussion: https://postgr.es/m/aNPSp1-RIAs3skZm@msg.df7cb.de Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7d129ba54e7425baf43aa518d417ba3e4e94a443 Modified Files -------------- src/test/ssl/t/001_ssltests.pl | 42 +++++++++++++++++++----------------------- 1 file changed, 19 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Avoid warnings in tests when openssl binary isn't available @ 2025-10-17 13:11 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Daniel Gustafsson @ 2025-10-17 13:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid warnings in tests when openssl binary isn't available The SSL tests for pg_stat_ssl tries to exactly match the serial from the certificate by extracting it with the openssl binary. If that fails due to the binary not being available, a fallback match is used, but the attempt to execute a missing binary adds a warning to the output which can confuse readers for a failure in the test. Fix by only attempting if the openssl binary was found by autoconf/meson. Backpatch down to v16 where commit c8e4030d1bdd made the test use the OPENSSL variable from autoconf/meson instead of a hard- coded value. Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Christoph Berg <myon@debian.org> Discussion: https://postgr.es/m/aNPSp1-RIAs3skZm@msg.df7cb.de Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/150a1b328778b1594f543057b6d3fbb78178f8b2 Modified Files -------------- src/test/ssl/t/001_ssltests.pl | 42 +++++++++++++++++++----------------------- 1 file changed, 19 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Avoid warnings in tests when openssl binary isn't available @ 2025-10-17 13:11 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Daniel Gustafsson @ 2025-10-17 13:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid warnings in tests when openssl binary isn't available The SSL tests for pg_stat_ssl tries to exactly match the serial from the certificate by extracting it with the openssl binary. If that fails due to the binary not being available, a fallback match is used, but the attempt to execute a missing binary adds a warning to the output which can confuse readers for a failure in the test. Fix by only attempting if the openssl binary was found by autoconf/meson. Backpatch down to v16 where commit c8e4030d1bdd made the test use the OPENSSL variable from autoconf/meson instead of a hard- coded value. Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Christoph Berg <myon@debian.org> Discussion: https://postgr.es/m/aNPSp1-RIAs3skZm@msg.df7cb.de Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f01c4eb4e901522859367ddfef69098224b36321 Modified Files -------------- src/test/ssl/t/001_ssltests.pl | 42 +++++++++++++++++++----------------------- 1 file changed, 19 insertions(+), 23 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Avoid warnings in tests when openssl binary isn't available @ 2025-10-17 13:12 Daniel Gustafsson <dgustafsson@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Daniel Gustafsson @ 2025-10-17 13:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Avoid warnings in tests when openssl binary isn't available The SSL tests for pg_stat_ssl tries to exactly match the serial from the certificate by extracting it with the openssl binary. If that fails due to the binary not being available, a fallback match is used, but the attempt to execute a missing binary adds a warning to the output which can confuse readers for a failure in the test. Fix by only attempting if the openssl binary was found by autoconf/meson. Backpatch down to v16 where commit c8e4030d1bdd made the test use the OPENSSL variable from autoconf/meson instead of a hard- coded value. Author: Daniel Gustafsson <daniel@yesql.se> Reported-by: Christoph Berg <myon@debian.org> Discussion: https://postgr.es/m/aNPSp1-RIAs3skZm@msg.df7cb.de Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bf5b26525b28a2abf8eef368921c12fdeaddc0d8 Modified Files -------------- src/test/ssl/t/001_ssltests.pl | 40 +++++++++++++++++++--------------------- 1 file changed, 19 insertions(+), 21 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-10-17 13:12 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-17 13:05 pgsql: Avoid warnings in tests when openssl binary isn't available Daniel Gustafsson <dgustafsson@postgresql.org> 2025-10-17 13:11 pgsql: Avoid warnings in tests when openssl binary isn't available Daniel Gustafsson <dgustafsson@postgresql.org> 2025-10-17 13:11 pgsql: Avoid warnings in tests when openssl binary isn't available Daniel Gustafsson <dgustafsson@postgresql.org> 2025-10-17 13:12 pgsql: Avoid warnings in tests when openssl binary isn't available Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox