pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix Coverity issue reported in commit a850be2fe. 2+ messages / 2 participants [nested] [flat]
* pgsql: Fix Coverity issue reported in commit a850be2fe. @ 2025-09-09 03:28 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2025-09-09 03:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Coverity issue reported in commit a850be2fe. Address a potential SIGSEGV that may occur when the tablesync worker attempts to locate a deleted row while applying changes. This situation arises during conflict detection for update-deleted scenarios. To prevent this crash, ensure that the operation is errored out early if the leader apply worker is unavailable. Since the leader worker maintains the necessary conflict detection metadata, proceeding without it serves no purpose and risks reporting incorrect conflict type. In the passing, improve a nearby comment. Reported by Tom Lane as per Coverity Author: shveta malik <shveta.malik@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Discussion: https://postgr.es/m/334468.1757280992@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5ac3c1ac22cb325844d0bee37f79f2c11931b32e Modified Files -------------- src/backend/replication/logical/worker.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix Coverity issue reported in commit 2273fa32bce. @ 2025-10-19 00:34 Tatsuo Ishii <ishii@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tatsuo Ishii @ 2025-10-19 00:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Coverity issue reported in commit 2273fa32bce. Coverity complains that the return value from gettuple_eval_partition (stored in variable "datum") in a do..while loop in WinGetFuncArgInPartition is overwritten when exiting the while loop. This commit tries to fix the issue by changing the gettuple_eval_partition call to: (void) gettuple_eval_partition() explicitly stating that we discard the return value. We are just interested in whether we are inside or outside of partition, NULL or NOT NULL here. Also enhance some comments for easier code reading. Reported-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/aPCOabSE4VfJLaky%40paquier.xyz Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/dd766a441d69d16d1c8ab0d3a41a10649702d202 Modified Files -------------- src/backend/executor/nodeWindowAgg.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-10-19 00:34 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-09-09 03:28 pgsql: Fix Coverity issue reported in commit a850be2fe. Amit Kapila <akapila@postgresql.org> 2025-10-19 00:34 pgsql: Fix Coverity issue reported in commit 2273fa32bce. Tatsuo Ishii <ishii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox