pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. @ 2025-10-22 17:38 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2025-10-22 17:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leaks in pg_combinebackup/reconstruct.c. One code path forgot to free the separately-malloc'd filename part of a struct rfile. Another place freed the filename but forgot the struct rfile itself. These seem worth fixing because with a large backup we could be dealing with many files. Coverity found the bug in make_rfile(). I found the other one by manual inspection. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9224c3025243a3daeb49fa58b948c6e1fdf99501 Modified Files -------------- src/bin/pg_combinebackup/reconstruct.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. @ 2025-10-22 17:38 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2025-10-22 17:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leaks in pg_combinebackup/reconstruct.c. One code path forgot to free the separately-malloc'd filename part of a struct rfile. Another place freed the filename but forgot the struct rfile itself. These seem worth fixing because with a large backup we could be dealing with many files. Coverity found the bug in make_rfile(). I found the other one by manual inspection. Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e2072b47b9abc7d298d242217919d3d0d9415fca Modified Files -------------- src/bin/pg_combinebackup/reconstruct.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. @ 2025-10-22 17:38 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 3+ messages in thread From: Tom Lane @ 2025-10-22 17:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix memory leaks in pg_combinebackup/reconstruct.c. One code path forgot to free the separately-malloc'd filename part of a struct rfile. Another place freed the filename but forgot the struct rfile itself. These seem worth fixing because with a large backup we could be dealing with many files. Coverity found the bug in make_rfile(). I found the other one by manual inspection. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4eb6992af1954cd81f4a8b503e8c45bae2a9c1fe Modified Files -------------- src/bin/pg_combinebackup/reconstruct.c | 2 ++ 1 file changed, 2 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-10-22 17:38 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-22 17:38 pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-22 17:38 pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-22 17:38 pgsql: Fix memory leaks in pg_combinebackup/reconstruct.c. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox