pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7b542cdbcdcc8676c38ebac940d81fa808081681 Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/39d24475c18059a2fe1de1d05352fd5eed6092b3 Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a8838689594d95a3c6342cb86b2be8a3add2d4d1 Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e7a3fae39e338c21b7c9ba8307775b410b4bd057 Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9f9a04368f8055c1851f5071add393b380d1cc52 Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dc0a208ac2e9435418a0660e5b42c52fd72284bb Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. @ 2025-10-23 16:33 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2025-10-23 16:33 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. These two functions expect there to be room to insert another item in the FreePageBtree's array, but their assertions were too weak to guarantee that. This has little practical effect granting that the callers are not buggy, but it seems to be misleading late-model Coverity into complaining about possible array overrun. Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/799984.1761150474@sss.pgh.pa.us Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/05d8a0869ea491ff9e989750dd23e190e77698c4 Modified Files -------------- src/backend/utils/mmgr/freepage.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-10-23 16:33 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us> 2025-10-23 16:33 pgsql: Fix off-by-one Asserts in FreePageBtreeInsertInternal/Leaf. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox