pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_createsubscriber: reword dry-run log messages 2+ messages / 1 participants [nested] [flat]
* pgsql: pg_createsubscriber: reword dry-run log messages @ 2025-10-31 17:50 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2025-10-31 17:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_createsubscriber: reword dry-run log messages The original messages were confusing in dry-run mode in that they state that something is being done, when in reality it isn't. Use alternative wording in that case, to make the distinction clear. Author: Peter Smith <smithpb2250@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Euler Taveira <euler@eulerto.com> Backpatch-through: 18 Discussion: https://postgr.es/m/CAHut+PsvQJQnQO0KT0S2oegenkvJ8FUuY-QS5syyqmT24R2xFQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2648eab3779b0204368f785f9df84de01270e537 Modified Files -------------- src/bin/pg_basebackup/pg_createsubscriber.c | 111 +++++++++++++-------- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 6 +- 2 files changed, 75 insertions(+), 42 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pg_createsubscriber: reword dry-run log messages @ 2025-10-31 17:50 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 2+ messages in thread From: Álvaro Herrera @ 2025-10-31 17:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_createsubscriber: reword dry-run log messages The original messages were confusing in dry-run mode in that they state that something is being done, when in reality it isn't. Use alternative wording in that case, to make the distinction clear. Author: Peter Smith <smithpb2250@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Euler Taveira <euler@eulerto.com> Backpatch-through: 18 Discussion: https://postgr.es/m/CAHut+PsvQJQnQO0KT0S2oegenkvJ8FUuY-QS5syyqmT24R2xFQ@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c25314d5364e284d137d30c5110727dbe0068d8b Modified Files -------------- src/bin/pg_basebackup/pg_createsubscriber.c | 101 ++++++++++++++------- src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 6 +- 2 files changed, 70 insertions(+), 37 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-10-31 17:50 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-10-31 17:50 pgsql: pg_createsubscriber: reword dry-run log messages Álvaro Herrera <alvherre@kurilemu.de> 2025-10-31 17:50 pgsql: pg_createsubscriber: reword dry-run log messages Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox