pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Tighten check for generated column in partition key expression 7+ messages / 1 participants [nested] [flat]
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 13:48 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 13:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/040cc5f3c782839ed30816671c5b5f36df0d2398 Modified Files -------------- src/backend/commands/tablecmds.c | 90 ++++++++++++++----------- src/test/regress/expected/generated_stored.out | 15 +++++ src/test/regress/expected/generated_virtual.out | 15 +++++ src/test/regress/sql/generated_stored.sql | 3 + src/test/regress/sql/generated_virtual.sql | 3 + 5 files changed, 86 insertions(+), 40 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 13:48 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 13:48 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ba99c9491c442e3640092c8cae380d9353721f3e Modified Files -------------- src/backend/commands/tablecmds.c | 90 ++++++++++++++----------- src/test/regress/expected/generated_stored.out | 15 +++++ src/test/regress/expected/generated_virtual.out | 15 +++++ src/test/regress/sql/generated_stored.sql | 3 + src/test/regress/sql/generated_virtual.sql | 3 + 5 files changed, 86 insertions(+), 40 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 14:42 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 14:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7180d56c5609166ac9bd7203e7ac0ad50bf400ce Modified Files -------------- src/backend/commands/tablecmds.c | 86 ++++++++++++++++++--------------- src/test/regress/expected/generated.out | 15 ++++++ src/test/regress/sql/generated.sql | 3 ++ 3 files changed, 66 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 14:42 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 14:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/643a5e96c7887e211e1c963f78ce3adaf9ceeb35 Modified Files -------------- src/backend/commands/tablecmds.c | 86 ++++++++++++++++++--------------- src/test/regress/expected/generated.out | 15 ++++++ src/test/regress/sql/generated.sql | 3 ++ 3 files changed, 66 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 14:42 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 14:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/04345d7a423ab60016824e672da578941841b7d1 Modified Files -------------- src/backend/commands/tablecmds.c | 86 ++++++++++++++++++--------------- src/test/regress/expected/generated.out | 15 ++++++ src/test/regress/sql/generated.sql | 3 ++ 3 files changed, 66 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 14:42 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 14:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7f239c72a897f7e0f884f92ea2f92efde92c60f8 Modified Files -------------- src/backend/commands/tablecmds.c | 86 ++++++++++++++++++--------------- src/test/regress/expected/generated.out | 15 ++++++ src/test/regress/sql/generated.sql | 3 ++ 3 files changed, 66 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Tighten check for generated column in partition key expression @ 2025-11-04 14:42 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 7+ messages in thread From: Peter Eisentraut @ 2025-11-04 14:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Tighten check for generated column in partition key expression A generated column may end up being part of the partition key expression, if it's specified as an expression e.g. "(<generated column name>)" or if the partition key expression contains a whole-row reference, even though we do not allow a generated column to be part of partition key expression. Fix this hole. Co-authored-by: jian he <jian.universality@gmail.com> Co-authored-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> Discussion: https://www.postgresql.org/message-id/flat/CACJufxF%3DWDGthXSAQr9thYUsfx_1_t9E6N8tE3B8EqXcVoVfQw%40m... Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0b44f2443f699b54d8036ac64a048dd6f59adb3a Modified Files -------------- src/backend/commands/tablecmds.c | 86 ++++++++++++++++++--------------- src/test/regress/expected/generated.out | 15 ++++++ src/test/regress/sql/generated.sql | 3 ++ 3 files changed, 66 insertions(+), 38 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-11-04 14:42 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-04 13:48 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org> 2025-11-04 13:48 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org> 2025-11-04 14:42 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org> 2025-11-04 14:42 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org> 2025-11-04 14:42 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org> 2025-11-04 14:42 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org> 2025-11-04 14:42 pgsql: Tighten check for generated column in partition key expression Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox