pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix snapshot handling bug in recent BRIN fix 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ef81697fee774d3e21e0c479f3f9515a7d0f256f Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8733f0b54c05239e059e473c46c1800dcd37cd40 Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3b5007347b5db0fa34cb54773be89e22f5d68b61 Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/65b0d1f74098d845f088d53b8922884a05db2f9c Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/20442cf5075da987dee42d7a31b1f5065d9d2c27 Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/0a3d27bfe0fb229253aa95feccd0360530b7edd8 Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix snapshot handling bug in recent BRIN fix @ 2025-11-04 19:35 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-04 19:35 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix snapshot handling bug in recent BRIN fix Commit a95e3d84c0e0 added ActiveSnapshot push+pop when processing work-items (BRIN autosummarization), but forgot to handle the case of a transaction failing during the run, which drops the snapshot untimely. Fix by making the pop conditional on an element being actually there. Author: Álvaro Herrera <alvherre@kurilemu.de> Backpatch-through: 13 Discussion: https://postgr.es/m/202511041648.nofajnuddmwk@alvherre.pgsql Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/bcfbd3f747d7f4403d8b53d1c471557c391d613f Modified Files -------------- src/backend/postmaster/autovacuum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-11-04 19:35 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de> 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de> 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de> 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de> 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de> 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de> 2025-11-04 19:35 pgsql: Fix snapshot handling bug in recent BRIN fix Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox