pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: jit: Fix accidentally-harmless type confusion 7+ messages / 1 participants [nested] [flat]
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2d83d729d5a1a6cc5c62bf3a932fdb508ce3d1ac Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/850b7da15b8dc5d479181095fde89be340680a06 Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3e45d8c67fe0e0b6229fb356fa91e67a3617d419 Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0418716e1c694fdc84a26f2551e764ee83e21520 Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0909a2971ced9a894ecbb4753bc770aa0923c044 Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/7609b342c3bf74f93522061962a58add42185790 Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: jit: Fix accidentally-harmless type confusion @ 2025-11-05 01:04 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2025-11-05 01:04 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org jit: Fix accidentally-harmless type confusion In 2a0faed9d702, which added JIT compilation support for expressions, I accidentally used sizeof(LLVMBasicBlockRef *) instead of sizeof(LLVMBasicBlockRef) as part of computing the size of an allocation. That turns out to have no real negative consequences due to LLVMBasicBlockRef being a pointer itself (and thus having the same size). It still is wrong and confusing, so fix it. Reported by coverity. Backpatch-through: 13 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5b45f7ee7946dc2de9446ba1da71f839de369401 Modified Files -------------- src/backend/jit/llvm/llvmjit_expr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-11-05 01:04 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de> 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de> 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de> 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de> 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de> 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de> 2025-11-05 01:04 pgsql: jit: Fix accidentally-harmless type confusion Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox