pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix comments for ChangeVarNodes() and related functions
2+ messages / 1 participants
[nested] [flat]

* pgsql: Fix comments for ChangeVarNodes() and related functions
@ 2025-11-05 03:30  Richard Guo <rguo@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Richard Guo @ 2025-11-05 03:30 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix comments for ChangeVarNodes() and related functions

The comment for ChangeVarNodes() refers to a parameter named
change_RangeTblRef, which does not exist in the code.

The comment for ChangeVarNodesExtended() contains an extra space,
while the comment for replace_relid_callback() has an awkward line
break and a typo.

This patch fixes these issues and revises some sentences for smoother
wording.

Oversights in commits ab42d643c and fc069a3a6.

Author: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAMbWs480j16HC1JtjKCgj5WshivT8ZJYkOfTyZAM0POjFomJkg@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/59dec6c0b09f717e4ce78d54f578d56ef93bcc53

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c | 18 +++++++++---------
src/backend/rewrite/rewriteManip.c        | 19 ++++++++-----------
2 files changed, 17 insertions(+), 20 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix comments for ChangeVarNodes() and related functions
@ 2025-11-05 03:32  Richard Guo <rguo@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Richard Guo @ 2025-11-05 03:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix comments for ChangeVarNodes() and related functions

The comment for ChangeVarNodes() refers to a parameter named
change_RangeTblRef, which does not exist in the code.

The comment for ChangeVarNodesExtended() contains an extra space,
while the comment for replace_relid_callback() has an awkward line
break and a typo.

This patch fixes these issues and revises some sentences for smoother
wording.

Oversights in commits ab42d643c and fc069a3a6.

Author: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/CAMbWs480j16HC1JtjKCgj5WshivT8ZJYkOfTyZAM0POjFomJkg@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b166a715262e84b135f70d18020c32329038dba9

Modified Files
--------------
src/backend/optimizer/plan/analyzejoins.c | 18 +++++++++---------
src/backend/rewrite/rewriteManip.c        | 19 ++++++++-----------
2 files changed, 17 insertions(+), 20 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2025-11-05 03:32 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-05 03:30 pgsql: Fix comments for ChangeVarNodes() and related functions Richard Guo <rguo@postgresql.org>
2025-11-05 03:32 pgsql: Fix comments for ChangeVarNodes() and related functions Richard Guo <rguo@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox