pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: ci: Add missing "set -e" to scripts run by su. 5+ messages / 1 participants [nested] [flat]
* pgsql: ci: Add missing "set -e" to scripts run by su. @ 2025-11-06 01:27 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-11-06 01:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Add missing "set -e" to scripts run by su. If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/cf638b46aff2ccb8d4811e3b5d8a2c2410638190 Modified Files -------------- .cirrus.tasks.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: ci: Add missing "set -e" to scripts run by su. @ 2025-11-06 01:28 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-11-06 01:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Add missing "set -e" to scripts run by su. If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ae2381025a4c77662ed5a56c062cbf3355c3d618 Modified Files -------------- .cirrus.tasks.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: ci: Add missing "set -e" to scripts run by su. @ 2025-11-06 01:28 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-11-06 01:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Add missing "set -e" to scripts run by su. If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/61cd67425f1ad907c02cd2470eff69ba85585ed2 Modified Files -------------- .cirrus.tasks.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: ci: Add missing "set -e" to scripts run by su. @ 2025-11-06 01:28 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-11-06 01:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Add missing "set -e" to scripts run by su. If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4da1f66fae836c4579ea38fe6d1d8fa2e6e9faf2 Modified Files -------------- .cirrus.tasks.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: ci: Add missing "set -e" to scripts run by su. @ 2025-11-06 01:28 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 5+ messages in thread From: Thomas Munro @ 2025-11-06 01:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org ci: Add missing "set -e" to scripts run by su. If any shell command fails, the whole script should fail. To avoid future omissions, add this even for single-command scripts that use su with heredoc syntax, as they might be extended or copied-and-pasted. Extracted from a larger patch that wanted to use #error during compilation, leading to the diagnosis of this problem. Reviewed-by: Tristan Partin <tristan@partin.io> (earlier version) Discussion: https://postgr.es/m/DDZP25P4VZ48.3LWMZBGA1K9RH%40partin.io Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c3359d1cf5e563b89f5dc1c3be40d7c045cb99cb Modified Files -------------- .cirrus.tasks.yml | 3 +++ 1 file changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2025-11-06 01:28 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-06 01:27 pgsql: ci: Add missing "set -e" to scripts run by su. Thomas Munro <tmunro@postgresql.org> 2025-11-06 01:28 pgsql: ci: Add missing "set -e" to scripts run by su. Thomas Munro <tmunro@postgresql.org> 2025-11-06 01:28 pgsql: ci: Add missing "set -e" to scripts run by su. Thomas Munro <tmunro@postgresql.org> 2025-11-06 01:28 pgsql: ci: Add missing "set -e" to scripts run by su. Thomas Munro <tmunro@postgresql.org> 2025-11-06 01:28 pgsql: ci: Add missing "set -e" to scripts run by su. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox