pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Disallow generated columns in COPY WHERE clause
7+ messages / 1 participants
[nested] [flat]
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Virtual generated columns currently error out ("unexpected virtual
generated column reference"). They could probably work if we expand
them in the right place, but for now let's keep them consistent with
the stored variant. This doesn't change the behavior, it only gives a
nicer error message.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/aa606b9316a334cbc8c48560c72235f9e48e47bf
Modified Files
--------------
src/backend/commands/copy.c | 39 +++++++++++++++++++++++++
src/test/regress/expected/generated_stored.out | 6 ++++
src/test/regress/expected/generated_virtual.out | 6 ++++
src/test/regress/sql/generated_stored.sql | 4 +++
src/test/regress/sql/generated_virtual.sql | 4 +++
5 files changed, 59 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/26958f4d99b16b1c638e6d43d46623e9c79579d5
Modified Files
--------------
src/backend/commands/copy.c | 37 +++++++++++++++++++++++++++++++++
src/test/regress/expected/generated.out | 6 ++++++
src/test/regress/sql/generated.sql | 4 ++++
3 files changed, 47 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Virtual generated columns currently error out ("unexpected virtual
generated column reference"). They could probably work if we expand
them in the right place, but for now let's keep them consistent with
the stored variant. This doesn't change the behavior, it only gives a
nicer error message.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0f9e0068bc62c98557d93ffeb484231162093304
Modified Files
--------------
src/backend/commands/copy.c | 39 +++++++++++++++++++++++++
src/test/regress/expected/generated_stored.out | 6 ++++
src/test/regress/expected/generated_virtual.out | 6 ++++
src/test/regress/sql/generated_stored.sql | 4 +++
src/test/regress/sql/generated_virtual.sql | 4 +++
5 files changed, 59 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ccfe28eb42370c1ce7b62c03fc4f2081ab6ba25d
Modified Files
--------------
src/backend/commands/copy.c | 37 +++++++++++++++++++++++++++++++++
src/test/regress/expected/generated.out | 6 ++++++
src/test/regress/sql/generated.sql | 4 ++++
3 files changed, 47 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8278737bfd0a37b68121a42a0b0a6775488adb48
Modified Files
--------------
src/backend/commands/copy.c | 37 +++++++++++++++++++++++++++++++++
src/test/regress/expected/generated.out | 6 ++++++
src/test/regress/sql/generated.sql | 4 ++++
3 files changed, 47 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3717849e622d6d38be8f021cf230903d70926d5a
Modified Files
--------------
src/backend/commands/copy.c | 37 +++++++++++++++++++++++++++++++++
src/test/regress/expected/generated.out | 6 ++++++
src/test/regress/sql/generated.sql | 4 ++++
3 files changed, 47 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Disallow generated columns in COPY WHERE clause
@ 2025-11-06 13:09 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 7+ messages in thread
From: Peter Eisentraut @ 2025-11-06 13:09 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Disallow generated columns in COPY WHERE clause
Stored generated columns are not yet computed when the filtering
happens, so we need to prohibit them to avoid incorrect behavior.
Co-authored-by: jian he <jian.universality@gmail.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxHb8YPQ095R_pYDr77W9XKNaXg5Rzy-WP525mkq+hRM3g@mail....
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/07f787e57399ad6108c181b020723db24fa1dbe0
Modified Files
--------------
src/backend/commands/copy.c | 37 +++++++++++++++++++++++++++++++++
src/test/regress/expected/generated.out | 6 ++++++
src/test/regress/sql/generated.sql | 4 ++++
3 files changed, 47 insertions(+)
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-11-06 13:09 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
2025-11-06 13:09 pgsql: Disallow generated columns in COPY WHERE clause Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox