pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Introduce XLogRecPtrIsValid() 7+ messages / 1 participants [nested] [flat]
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/06edbed478625829b19c35d0c17d805be588afa6 Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c0031d461324ca6063e96cc28ce78b75aa778112 Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/33727aff18d05f24232e7fffc3bde310203ece96 Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/723cc84db50a7b822f89c3ea90cbd39d530d1f70 Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/49b45999f3b213c00cae2ef4f42d56e88c96b709 Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d2965f627fe35bfc9c212528159d95f46b8e83ef Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Introduce XLogRecPtrIsValid() @ 2025-11-06 18:21 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 7+ messages in thread From: Álvaro Herrera @ 2025-11-06 18:21 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Introduce XLogRecPtrIsValid() XLogRecPtrIsInvalid() is inconsistent with the affirmative form of macros used for other datatypes, and leads to awkward double negatives in a few places. This commit introduces XLogRecPtrIsValid(), which allows code to be written more naturally. This patch only adds the new macro. XLogRecPtrIsInvalid() is left in place, and all existing callers remain untouched. This means all supported branches can accept hypothetical bug fixes that use the new macro, and at the same time any code that compiled with the original formulation will continue to silently compile just fine. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/aQB7EvGqrbZXrMlg@ip-10-97-1-34.eu-west-3.compute.internal Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/20bafb0972882eaf0fb50349fc4023e1e5505a57 Modified Files -------------- src/include/access/xlogdefs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-11-06 18:21 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de> 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de> 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de> 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de> 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de> 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de> 2025-11-06 18:21 pgsql: Introduce XLogRecPtrIsValid() Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox