pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Add note about CreateStatistics()'s selective use of check_right 6+ messages / 1 participants [nested] [flat]
* pgsql: Add note about CreateStatistics()'s selective use of check_right @ 2025-11-14 19:20 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-11-14 19:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this function's lookup could return a different answer than the caller's. This commit adds a note to this effect so that we remember it down the road. Reviewed-by: Noah Misch <noah@leadboat.com> Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7506bdbbf45ea757f67162a352196976379ccdd7 Modified Files -------------- src/backend/commands/statscmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add note about CreateStatistics()'s selective use of check_right @ 2025-11-14 19:20 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-11-14 19:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this function's lookup could return a different answer than the caller's. This commit adds a note to this effect so that we remember it down the road. Reviewed-by: Noah Misch <noah@leadboat.com> Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/505ce19a205add23934f61bbced98a1b9a74ec1f Modified Files -------------- src/backend/commands/statscmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add note about CreateStatistics()'s selective use of check_right @ 2025-11-14 19:20 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-11-14 19:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this function's lookup could return a different answer than the caller's. This commit adds a note to this effect so that we remember it down the road. Reviewed-by: Noah Misch <noah@leadboat.com> Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/29cf93b4b2a63273097c37f7dd0a0aed0f466798 Modified Files -------------- src/backend/commands/statscmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add note about CreateStatistics()'s selective use of check_right @ 2025-11-14 19:20 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-11-14 19:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this function's lookup could return a different answer than the caller's. This commit adds a note to this effect so that we remember it down the road. Reviewed-by: Noah Misch <noah@leadboat.com> Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/414e1ece9d71cece76fcab0abca6816605cb7db5 Modified Files -------------- src/backend/commands/statscmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add note about CreateStatistics()'s selective use of check_right @ 2025-11-14 19:20 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-11-14 19:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this function's lookup could return a different answer than the caller's. This commit adds a note to this effect so that we remember it down the road. Reviewed-by: Noah Misch <noah@leadboat.com> Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d61af52ad1fcb86a6893c27e40aca492a57f35bc Modified Files -------------- src/backend/commands/statscmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Add note about CreateStatistics()'s selective use of check_right @ 2025-11-14 19:20 Nathan Bossart <nathan@postgresql.org> 0 siblings, 0 replies; 6+ messages in thread From: Nathan Bossart @ 2025-11-14 19:20 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Add note about CreateStatistics()'s selective use of check_rights. Commit 5e4fcbe531 added a check_rights parameter to this function for use by ALTER TABLE commands that re-create statistics objects. However, we intentionally ignore check_rights when verifying relation ownership because this function's lookup could return a different answer than the caller's. This commit adds a note to this effect so that we remember it down the road. Reviewed-by: Noah Misch <noah@leadboat.com> Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4c179ccb05062ebf29c2936e67842010d71742d0 Modified Files -------------- src/backend/commands/statscmds.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-11-14 19:20 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-11-14 19:20 pgsql: Add note about CreateStatistics()'s selective use of check_right Nathan Bossart <nathan@postgresql.org> 2025-11-14 19:20 pgsql: Add note about CreateStatistics()'s selective use of check_right Nathan Bossart <nathan@postgresql.org> 2025-11-14 19:20 pgsql: Add note about CreateStatistics()'s selective use of check_right Nathan Bossart <nathan@postgresql.org> 2025-11-14 19:20 pgsql: Add note about CreateStatistics()'s selective use of check_right Nathan Bossart <nathan@postgresql.org> 2025-11-14 19:20 pgsql: Add note about CreateStatistics()'s selective use of check_right Nathan Bossart <nathan@postgresql.org> 2025-11-14 19:20 pgsql: Add note about CreateStatistics()'s selective use of check_right Nathan Bossart <nathan@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox