pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix incorrect IndexOptInfo header comment
6+ messages / 1 participants
[nested] [flat]

* pgsql: Fix incorrect IndexOptInfo header comment
@ 2025-11-24 04:00  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: David Rowley @ 2025-11-24 04:00 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix incorrect IndexOptInfo header comment

The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/07d1dc3aebe4391a2711e951c69df2bb56447f8a

Modified Files
--------------
src/include/nodes/pathnodes.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix incorrect IndexOptInfo header comment
@ 2025-11-24 04:01  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: David Rowley @ 2025-11-24 04:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix incorrect IndexOptInfo header comment

The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f4e68a32a0cc0ff4b17ebe4e16be18ff15ff97a8

Modified Files
--------------
src/include/nodes/pathnodes.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix incorrect IndexOptInfo header comment
@ 2025-11-24 04:01  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: David Rowley @ 2025-11-24 04:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix incorrect IndexOptInfo header comment

The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/232e0f5de41b904daa111dbd274c2cb2028991a4

Modified Files
--------------
src/include/nodes/pathnodes.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix incorrect IndexOptInfo header comment
@ 2025-11-24 04:01  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: David Rowley @ 2025-11-24 04:01 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix incorrect IndexOptInfo header comment

The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/14cdab029287b510fb6872370358feab470bef1f

Modified Files
--------------
src/include/nodes/pathnodes.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix incorrect IndexOptInfo header comment
@ 2025-11-24 04:02  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: David Rowley @ 2025-11-24 04:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix incorrect IndexOptInfo header comment

The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ea757e8012961cd9875c1bfcb16c655c515ce791

Modified Files
--------------
src/include/nodes/pathnodes.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Fix incorrect IndexOptInfo header comment
@ 2025-11-24 04:02  David Rowley <drowley@postgresql.org>
  0 siblings, 0 replies; 6+ messages in thread

From: David Rowley @ 2025-11-24 04:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix incorrect IndexOptInfo header comment

The comment incorrectly indicated that indexcollations[] stored
collations for both key columns and INCLUDE columns, but in reality it
only has elements for the key columns.  canreturn[] didn't get a mention,
so add that while we're here.

Author: Junwang Zhao <zhjwpku@gmail.com>
Reviewed-by: David Rowley <dgrowleyml@gmail.com>
Discussion: https://postgr.es/m/CAEG8a3LwbZgMKOQ9CmZarX5DEipKivdHp5PZMOO-riL0w%3DL%3D4A%40mail.gmail.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ea36c2f6a9819bfee778d08f6b5877a356a2d195

Modified Files
--------------
src/include/nodes/pathnodes.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2025-11-24 04:02 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-24 04:00 pgsql: Fix incorrect IndexOptInfo header comment David Rowley <drowley@postgresql.org>
2025-11-24 04:01 pgsql: Fix incorrect IndexOptInfo header comment David Rowley <drowley@postgresql.org>
2025-11-24 04:01 pgsql: Fix incorrect IndexOptInfo header comment David Rowley <drowley@postgresql.org>
2025-11-24 04:01 pgsql: Fix incorrect IndexOptInfo header comment David Rowley <drowley@postgresql.org>
2025-11-24 04:02 pgsql: Fix incorrect IndexOptInfo header comment David Rowley <drowley@postgresql.org>
2025-11-24 04:02 pgsql: Fix incorrect IndexOptInfo header comment David Rowley <drowley@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox