pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix text substring search for non-deterministic collations. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix text substring search for non-deterministic collations. @ 2025-12-06 01:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2025-12-06 01:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix text substring search for non-deterministic collations. Due to an off-by-one error, the code failed to find matches at the end of the haystack. Fix by rewriting the loop. While at it, fix a comment that claimed that the function could find a zero-length match. Such a match could send a caller into an endless loop. However, zero-length matches only make sense with an empty search string, and that case is explicitly excluded by all callers. To make sure it stays that way, add an Assert and a comment. Bug: #19341 Reported-by: Adam Warland <adam.warland@infor.com> Author: Laurenz Albe <laurenz.albe@cybertec.at> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19341-1d9a22915edfec58@postgresql.org Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6dfce8420e99d8cf41ffb7da698caee57fd73eb7 Modified Files -------------- src/backend/utils/adt/varlena.c | 25 ++++++++++++++++++------- src/test/regress/expected/collate.icu.utf8.out | 7 +++++++ src/test/regress/sql/collate.icu.utf8.sql | 3 +++ 3 files changed, 28 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix text substring search for non-deterministic collations. @ 2025-12-06 01:10 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2025-12-06 01:10 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix text substring search for non-deterministic collations. Due to an off-by-one error, the code failed to find matches at the end of the haystack. Fix by rewriting the loop. While at it, fix a comment that claimed that the function could find a zero-length match. Such a match could send a caller into an endless loop. However, zero-length matches only make sense with an empty search string, and that case is explicitly excluded by all callers. To make sure it stays that way, add an Assert and a comment. Bug: #19341 Reported-by: Adam Warland <adam.warland@infor.com> Author: Laurenz Albe <laurenz.albe@cybertec.at> Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19341-1d9a22915edfec58@postgresql.org Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/18b349315ae7e00261732f514d6c91d713bb77d0 Modified Files -------------- src/backend/utils/adt/varlena.c | 25 ++++++++++++++++++------- src/test/regress/expected/collate.icu.utf8.out | 7 +++++++ src/test/regress/sql/collate.icu.utf8.sql | 3 +++ 3 files changed, 28 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-12-06 01:10 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-06 01:10 pgsql: Fix text substring search for non-deterministic collations. Tom Lane <tgl@sss.pgh.pa.us> 2025-12-06 01:10 pgsql: Fix text substring search for non-deterministic collations. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox