pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix failures with cross-version pg_upgrade tests 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix failures with cross-version pg_upgrade tests @ 2025-12-10 03:58 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-12-10 03:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix failures with cross-version pg_upgrade tests Buildfarm members skimmer and crake have reported that pg_upgrade running from v18 fails due to the changes of d52c24b0f808, with the expectations that the objects removed in the test module injection_points should still be present post upgrades, but the test module does not have them anymore. The origin of the issue is that the following test modules depend on injection_points, but they do not drop the extension once the tests finish, leaving its traces in the dumps used for the upgrades: - gin, down to v17 - typcache, down to v18 - nbtree, HEAD-only Test modules have no upgrade requirements, as they are used only for.. Tests, so there is no point in keeping them around. An alternative solution would be to drop the databases created by these modules in AdjustUpgrade.pm, but the solution of this commit to drop the extension is simpler. Note that there would be a catch if using a solution based on AdjustUpgrade.pm as the database name used for the test runs differs between configure and meson: - configure relies on USE_MODULE_DB for the database name unicity, that would build a database name based on the *first* entry of REGRESS, that lists all the SQL tests. - meson relies on a "name" field. For example, for the test module "gin", the regression database is named "regression_gin" under meson, while it is more complex for configure, as of "contrib_regression_gin_incomplete_splits". So a AdjustUpgrade.pm would need a set of DROP DATABASE IF EXISTS to solve this issue, to cope with each build system. The failure has been caused by d52c24b0f808, and the problem can happen with upgrade dumps from v17 and v18 to HEAD. This problem is not currently reachable in the back-branches, but it could be possible that a future change in injection_points in stable branches invalidates this theory, so this commit is applied down to v17 in the test modules that matter. Per discussion with Tom Lane and Heikki Linnakangas. Discussion: https://postgr.es/m/2899652.1765167313@sss.pgh.pa.us Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1d7b00dc14b8efd22f6e971756c2d9c052863234 Modified Files -------------- src/test/modules/gin/expected/gin_incomplete_splits.out | 1 + src/test/modules/gin/sql/gin_incomplete_splits.sql | 2 ++ src/test/modules/nbtree/expected/nbtree_half_dead_pages.out | 2 ++ src/test/modules/nbtree/expected/nbtree_incomplete_splits.out | 2 ++ src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql | 3 +++ src/test/modules/nbtree/sql/nbtree_incomplete_splits.sql | 3 +++ src/test/modules/typcache/expected/typcache_rel_type_cache.out | 1 + src/test/modules/typcache/sql/typcache_rel_type_cache.sql | 2 ++ 8 files changed, 16 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix failures with cross-version pg_upgrade tests @ 2025-12-10 03:58 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-12-10 03:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix failures with cross-version pg_upgrade tests Buildfarm members skimmer and crake have reported that pg_upgrade running from v18 fails due to the changes of d52c24b0f808, with the expectations that the objects removed in the test module injection_points should still be present post upgrades, but the test module does not have them anymore. The origin of the issue is that the following test modules depend on injection_points, but they do not drop the extension once the tests finish, leaving its traces in the dumps used for the upgrades: - gin, down to v17 - typcache, down to v18 - nbtree, HEAD-only Test modules have no upgrade requirements, as they are used only for.. Tests, so there is no point in keeping them around. An alternative solution would be to drop the databases created by these modules in AdjustUpgrade.pm, but the solution of this commit to drop the extension is simpler. Note that there would be a catch if using a solution based on AdjustUpgrade.pm as the database name used for the test runs differs between configure and meson: - configure relies on USE_MODULE_DB for the database name unicity, that would build a database name based on the *first* entry of REGRESS, that lists all the SQL tests. - meson relies on a "name" field. For example, for the test module "gin", the regression database is named "regression_gin" under meson, while it is more complex for configure, as of "contrib_regression_gin_incomplete_splits". So a AdjustUpgrade.pm would need a set of DROP DATABASE IF EXISTS to solve this issue, to cope with each build system. The failure has been caused by d52c24b0f808, and the problem can happen with upgrade dumps from v17 and v18 to HEAD. This problem is not currently reachable in the back-branches, but it could be possible that a future change in injection_points in stable branches invalidates this theory, so this commit is applied down to v17 in the test modules that matter. Per discussion with Tom Lane and Heikki Linnakangas. Discussion: https://postgr.es/m/2899652.1765167313@sss.pgh.pa.us Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1756b9f616b662f9a3c98f02d6fc2932a195d8e1 Modified Files -------------- src/test/modules/gin/expected/gin_incomplete_splits.out | 1 + src/test/modules/gin/sql/gin_incomplete_splits.sql | 2 ++ src/test/modules/typcache/expected/typcache_rel_type_cache.out | 1 + src/test/modules/typcache/sql/typcache_rel_type_cache.sql | 2 ++ 4 files changed, 6 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix failures with cross-version pg_upgrade tests @ 2025-12-10 03:58 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2025-12-10 03:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix failures with cross-version pg_upgrade tests Buildfarm members skimmer and crake have reported that pg_upgrade running from v18 fails due to the changes of d52c24b0f808, with the expectations that the objects removed in the test module injection_points should still be present post upgrades, but the test module does not have them anymore. The origin of the issue is that the following test modules depend on injection_points, but they do not drop the extension once the tests finish, leaving its traces in the dumps used for the upgrades: - gin, down to v17 - typcache, down to v18 - nbtree, HEAD-only Test modules have no upgrade requirements, as they are used only for.. Tests, so there is no point in keeping them around. An alternative solution would be to drop the databases created by these modules in AdjustUpgrade.pm, but the solution of this commit to drop the extension is simpler. Note that there would be a catch if using a solution based on AdjustUpgrade.pm as the database name used for the test runs differs between configure and meson: - configure relies on USE_MODULE_DB for the database name unicity, that would build a database name based on the *first* entry of REGRESS, that lists all the SQL tests. - meson relies on a "name" field. For example, for the test module "gin", the regression database is named "regression_gin" under meson, while it is more complex for configure, as of "contrib_regression_gin_incomplete_splits". So a AdjustUpgrade.pm would need a set of DROP DATABASE IF EXISTS to solve this issue, to cope with each build system. The failure has been caused by d52c24b0f808, and the problem can happen with upgrade dumps from v17 and v18 to HEAD. This problem is not currently reachable in the back-branches, but it could be possible that a future change in injection_points in stable branches invalidates this theory, so this commit is applied down to v17 in the test modules that matter. Per discussion with Tom Lane and Heikki Linnakangas. Discussion: https://postgr.es/m/2899652.1765167313@sss.pgh.pa.us Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d0518e965e6489ff2df0a71953e56656c710141a Modified Files -------------- src/test/modules/gin/expected/gin_incomplete_splits.out | 1 + src/test/modules/gin/sql/gin_incomplete_splits.sql | 2 ++ 2 files changed, 3 insertions(+) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-12-10 03:58 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-10 03:58 pgsql: Fix failures with cross-version pg_upgrade tests Michael Paquier <michael@paquier.xyz> 2025-12-10 03:58 pgsql: Fix failures with cross-version pg_upgrade tests Michael Paquier <michael@paquier.xyz> 2025-12-10 03:58 pgsql: Fix failures with cross-version pg_upgrade tests Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox