pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix bogus extra arguments to query_safe in test 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix bogus extra arguments to query_safe in test @ 2025-12-10 17:58 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2025-12-10 17:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix bogus extra arguments to query_safe in test The test seemed to incorrectly think that query_safe() takes an argument that describes what the query does, similar to e.g. command_ok(). Until commit bd8d9c9bdf the extra arguments were harmless and were just ignored, but when commit bd8d9c9bdf introduced a new optional argument to query_safe(), the extra arguments started clashing with that, causing the test to fail. Backpatch to v17, that's the oldest branch where the test exists. The extra arguments didn't cause any trouble on the older branches, but they were clearly bogus anyway. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/820343bab30852142ddc50db3aa81ef58d7cb676 Modified Files -------------- src/test/modules/xid_wraparound/t/004_notify_freeze.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix bogus extra arguments to query_safe in test @ 2025-12-10 17:58 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2025-12-10 17:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix bogus extra arguments to query_safe in test The test seemed to incorrectly think that query_safe() takes an argument that describes what the query does, similar to e.g. command_ok(). Until commit bd8d9c9bdf the extra arguments were harmless and were just ignored, but when commit bd8d9c9bdf introduced a new optional argument to query_safe(), the extra arguments started clashing with that, causing the test to fail. Backpatch to v17, that's the oldest branch where the test exists. The extra arguments didn't cause any trouble on the older branches, but they were clearly bogus anyway. Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e08f338d0028af6f9f54616df1cb51009504eee3 Modified Files -------------- src/test/modules/xid_wraparound/t/004_notify_freeze.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix bogus extra arguments to query_safe in test @ 2025-12-10 17:58 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2025-12-10 17:58 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix bogus extra arguments to query_safe in test The test seemed to incorrectly think that query_safe() takes an argument that describes what the query does, similar to e.g. command_ok(). Until commit bd8d9c9bdf the extra arguments were harmless and were just ignored, but when commit bd8d9c9bdf introduced a new optional argument to query_safe(), the extra arguments started clashing with that, causing the test to fail. Backpatch to v17, that's the oldest branch where the test exists. The extra arguments didn't cause any trouble on the older branches, but they were clearly bogus anyway. Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/807b2f261d643944120d29bfab70937ebbd4aad6 Modified Files -------------- src/test/modules/xid_wraparound/t/004_notify_freeze.pl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-12-10 17:58 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-10 17:58 pgsql: Fix bogus extra arguments to query_safe in test Heikki Linnakangas <heikki.linnakangas@iki.fi> 2025-12-10 17:58 pgsql: Fix bogus extra arguments to query_safe in test Heikki Linnakangas <heikki.linnakangas@iki.fi> 2025-12-10 17:58 pgsql: Fix bogus extra arguments to query_safe in test Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox