pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: libpq-oauth: Don't translate internal errors 2+ messages / 1 participants [nested] [flat]
* pgsql: libpq-oauth: Don't translate internal errors @ 2025-12-15 22:28 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-12-15 22:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org libpq-oauth: Don't translate internal errors Some error messages are generated when OAuth multiplexer operations fail unexpectedly in the client. Álvaro pointed out that these are both difficult to translate idiomatically (as they use internal terminology heavily) and of dubious translation value to end users (since they're going to need to get developer help anyway). The response parsing engine has a similar issue. Remove these from the translation files by introducing internal variants of actx_error() and oauth_parse_set_error(). Suggested-by: Álvaro Herrera <alvherre@kurilemu.de> Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/CAOYmi%2BkQQ8vpRcoSrA5EQ98Wa3G6jFj1yRHs6mh1V7ohkTC7JA%40mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/301a1dcf00c82350aad642b872d263730cd87f8f Modified Files -------------- src/interfaces/libpq-oauth/oauth-curl.c | 85 +++++++++++++++++---------------- 1 file changed, 45 insertions(+), 40 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: libpq-oauth: Don't translate internal errors @ 2025-12-15 22:28 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-12-15 22:28 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org libpq-oauth: Don't translate internal errors Some error messages are generated when OAuth multiplexer operations fail unexpectedly in the client. Álvaro pointed out that these are both difficult to translate idiomatically (as they use internal terminology heavily) and of dubious translation value to end users (since they're going to need to get developer help anyway). The response parsing engine has a similar issue. Remove these from the translation files by introducing internal variants of actx_error() and oauth_parse_set_error(). Suggested-by: Álvaro Herrera <alvherre@kurilemu.de> Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/CAOYmi%2BkQQ8vpRcoSrA5EQ98Wa3G6jFj1yRHs6mh1V7ohkTC7JA%40mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aac25567fec10b7b2cc382654e5586acebec5431 Modified Files -------------- src/interfaces/libpq-oauth/oauth-curl.c | 85 +++++++++++++++++---------------- 1 file changed, 45 insertions(+), 40 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-12-15 22:28 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-15 22:28 pgsql: libpq-oauth: Don't translate internal errors Jacob Champion <jchampion@postgresql.org> 2025-12-15 22:28 pgsql: libpq-oauth: Don't translate internal errors Jacob Champion <jchampion@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox