pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
7+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2025-12-17 5b4fb2b97d Rename regress.so's .mo file to postgresql-regress-VERSION.mo.
* pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
@ 2025-12-15 23:38 Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 11:36 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
2025-12-17 11:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
0 siblings, 2 replies; 7+ messages in thread
From: Tom Lane @ 2025-12-15 23:38 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Revert "Avoid requiring Spanish locale to test NLS infrastructure."
This reverts commit 7db6809ced4406257a80766e4109c8be8e1ea744.
That doesn't seem to work with recent (last couple of years)
glibc, and the reasons are obscure. I can't let the farm stay
this broken for long.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/84a3778c79c2d28b4dc281d03ef2ab019b16483b
Modified Files
--------------
src/test/regress/expected/nls.out | 65 ++++++++++-----
src/test/regress/expected/nls_1.out | 49 ++++++-----
src/test/regress/expected/nls_2.out | 35 ++++++++
src/test/regress/po/C.po | 161 ------------------------------------
src/test/regress/po/LINGUAS | 2 +-
src/test/regress/po/es.po | 159 +++++++++++++++++++++++++++++++++++
src/test/regress/regress.c | 45 +++++-----
src/test/regress/sql/nls.sql | 35 ++++++--
8 files changed, 314 insertions(+), 237 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
@ 2025-12-17 11:36 ` Christoph Berg <myon@debian.org>
1 sibling, 0 replies; 7+ messages in thread
From: Christoph Berg @ 2025-12-17 11:36 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
Re: Tom Lane
> src/test/regress/po/es.po | 159 +++++++++++++++++++++++++++++++++++
The Debian package builds are complaining that there is now a
usr/share/locale/es/LC_MESSAGES/regress-19.mo
file that needs sorting into one of the .deb packages.
Since regress.so itself doesn't get installed by autoconf's Makefiles,
shouldn't that .mo file not get installed either? (Or resolve it the
other way round and install both.)
Christoph
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
@ 2025-12-17 11:57 ` Christoph Berg <myon@debian.org>
2025-12-17 15:29 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 7+ messages in thread
From: Christoph Berg @ 2025-12-17 11:57 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
Re: Tom Lane
> src/test/regress/po/es.po | 159 +++++++++++++++++++++++++++++++++++
The Debian package builds are complaining that there is now a
usr/share/locale/es/LC_MESSAGES/regress-19.mo
file that needs sorting into one of the .deb packages.
Since regress.so itself doesn't get installed by autoconf's Makefiles,
shouldn't that .mo file not get installed either? (Or resolve it the
other way round and install both.)
Christoph
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 11:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
@ 2025-12-17 15:29 ` Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 15:55 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
0 siblings, 1 reply; 7+ messages in thread
From: Tom Lane @ 2025-12-17 15:29 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; +Cc: pgsql-hackers@lists.postgresql.org
Christoph Berg <myon@debian.org> writes:
> The Debian package builds are complaining that there is now a
> usr/share/locale/es/LC_MESSAGES/regress-19.mo
> file that needs sorting into one of the .deb packages.
> Since regress.so itself doesn't get installed by autoconf's Makefiles,
> shouldn't that .mo file not get installed either? (Or resolve it the
> other way round and install both.)
Hm. I don't really care to revisit the decision not to install
regress.so. OTOH, if we don't install the .mo file, "make
installcheck" will not work, which is surely a nonstarter.
(Also, I see no provisions in either build system to build a
non-installed .mo file.)
Is it possible to override that packaging complaint?
regards, tom lane
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 11:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
2025-12-17 15:29 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
@ 2025-12-17 15:55 ` Christoph Berg <myon@debian.org>
2025-12-17 15:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 7+ messages in thread
From: Christoph Berg @ 2025-12-17 15:55 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers@lists.postgresql.org
Re: Tom Lane
> Is it possible to override that packaging complaint?
Sure, we'd just have to install it. It just seemed asymmetric to do
that when regress.so isn't installed. (TBH I've been pondering to do
that anyway to make re-running the regression tests later easier.)
"regress-19.mo" is a pretty generic name for a file installed in a
system-wide location. Perhaps it could be named postgresql-regress-19.mo?
(pg_regress(-19).mo doesn't exist yet, but might appear independently.)
Christoph
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 11:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
2025-12-17 15:29 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 15:55 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
@ 2025-12-17 15:57 ` Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 19:11 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 7+ messages in thread
From: Tom Lane @ 2025-12-17 15:57 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; +Cc: pgsql-hackers@lists.postgresql.org
Christoph Berg <myon@debian.org> writes:
> "regress-19.mo" is a pretty generic name for a file installed in a
> system-wide location. Perhaps it could be named postgresql-regress-19.mo?
> (pg_regress(-19).mo doesn't exist yet, but might appear independently.)
Fair point, I'll look into renaming that later.
regards, tom lane
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 11:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
2025-12-17 15:29 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 15:55 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Christoph Berg <myon@debian.org>
2025-12-17 15:57 ` Re: pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
@ 2025-12-17 19:11 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2025-12-17 19:11 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; +Cc: pgsql-hackers@lists.postgresql.org
I wrote:
> Christoph Berg <myon@debian.org> writes:
>> "regress-19.mo" is a pretty generic name for a file installed in a
>> system-wide location. Perhaps it could be named postgresql-regress-19.mo?
>> (pg_regress(-19).mo doesn't exist yet, but might appear independently.)
> Fair point, I'll look into renaming that later.
Done at 5b4fb2b97d2.
regards, tom lane
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2025-12-17 19:11 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-12-15 23:38 pgsql: Revert "Avoid requiring Spanish locale to test NLS infrastructur Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 11:36 ` Christoph Berg <myon@debian.org>
2025-12-17 11:57 ` Christoph Berg <myon@debian.org>
2025-12-17 15:29 ` Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 15:55 ` Christoph Berg <myon@debian.org>
2025-12-17 15:57 ` Tom Lane <tgl@sss.pgh.pa.us>
2025-12-17 19:11 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox