pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: oauth_validator: Avoid races in log_check() 2+ messages / 1 participants [nested] [flat]
* pgsql: oauth_validator: Avoid races in log_check() @ 2025-12-17 20:34 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-12-17 20:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org oauth_validator: Avoid races in log_check() Commit e0f373ee4 fixed up races in Cluster::connect_fails when using log_like. t/002_client.pl didn't get the memo, though, because it doesn't use Test::Cluster to perform its custom hook tests. (This is probably not an issue at the moment, since the log check is only done after authentication success and not failure, but there's no reason to wait for someone to hit it.) Introduce the fix, based on debug2 logging, to its use of log_check() as well, and move the logic into the test() helper so that any additions don't need to continually duplicate it. Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/CAOYmi%2BmrGg%2Bn_X2MOLgeWcj3v_M00gR8uz_D7mM8z%3DdX1JYVbg%40mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/ab8af1db43031544a5c01314bef9f0392bfde7f9 Modified Files -------------- src/test/modules/oauth_validator/t/002_client.pl | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: oauth_validator: Avoid races in log_check() @ 2025-12-17 20:34 Jacob Champion <jchampion@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jacob Champion @ 2025-12-17 20:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org oauth_validator: Avoid races in log_check() Commit e0f373ee4 fixed up races in Cluster::connect_fails when using log_like. t/002_client.pl didn't get the memo, though, because it doesn't use Test::Cluster to perform its custom hook tests. (This is probably not an issue at the moment, since the log check is only done after authentication success and not failure, but there's no reason to wait for someone to hit it.) Introduce the fix, based on debug2 logging, to its use of log_check() as well, and move the logic into the test() helper so that any additions don't need to continually duplicate it. Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/CAOYmi%2BmrGg%2Bn_X2MOLgeWcj3v_M00gR8uz_D7mM8z%3DdX1JYVbg%40mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c3df85756ceb0246958ef2b72c04aba51e52de13 Modified Files -------------- src/test/modules/oauth_validator/t/002_client.pl | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-12-17 20:34 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-17 20:34 pgsql: oauth_validator: Avoid races in log_check() Jacob Champion <jchampion@postgresql.org> 2025-12-17 20:34 pgsql: oauth_validator: Avoid races in log_check() Jacob Champion <jchampion@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox