pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Do not emit WAL for unlogged BRIN indexes
6+ messages / 1 participants
[nested] [flat]
* pgsql: Do not emit WAL for unlogged BRIN indexes
@ 2025-12-18 13:13 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 6+ messages in thread
From: Heikki Linnakangas @ 2025-12-18 13:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Do not emit WAL for unlogged BRIN indexes
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.
The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:
FATAL: could not create file "base/5/32819": File exists
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail...
Backpatch-through: 14
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/951b60f7abdcdeb37f2d73ad4822f278d2687c1c
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Do not emit WAL for unlogged BRIN indexes
@ 2025-12-18 13:13 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 6+ messages in thread
From: Heikki Linnakangas @ 2025-12-18 13:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Do not emit WAL for unlogged BRIN indexes
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.
The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:
FATAL: could not create file "base/5/32819": File exists
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail...
Backpatch-through: 14
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d77a5f98176ffaf3a537f4683ec87044c21bb98c
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Do not emit WAL for unlogged BRIN indexes
@ 2025-12-18 13:13 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 6+ messages in thread
From: Heikki Linnakangas @ 2025-12-18 13:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Do not emit WAL for unlogged BRIN indexes
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.
The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:
FATAL: could not create file "base/5/32819": File exists
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail...
Backpatch-through: 14
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4b6d096a0f99d684db60a9f99aef851ebe0a5fa3
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Do not emit WAL for unlogged BRIN indexes
@ 2025-12-18 13:13 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 6+ messages in thread
From: Heikki Linnakangas @ 2025-12-18 13:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Do not emit WAL for unlogged BRIN indexes
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.
The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:
FATAL: could not create file "base/5/32819": File exists
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail...
Backpatch-through: 14
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a5277700e47862e9f83b0695fb34ffff0ea2fa34
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Do not emit WAL for unlogged BRIN indexes
@ 2025-12-18 13:13 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 6+ messages in thread
From: Heikki Linnakangas @ 2025-12-18 13:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Do not emit WAL for unlogged BRIN indexes
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.
The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:
FATAL: could not create file "base/5/32819": File exists
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail...
Backpatch-through: 14
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/460d97020ac1955a293fe79d2789ae8f35ba69cf
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Do not emit WAL for unlogged BRIN indexes
@ 2025-12-18 13:13 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 6+ messages in thread
From: Heikki Linnakangas @ 2025-12-18 13:13 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Do not emit WAL for unlogged BRIN indexes
Operations on unlogged relations should not be WAL-logged. The
brin_initialize_empty_new_buffer() function didn't get the memo.
The function is only called when a concurrent update to a brin page
uses up space that we're just about to insert to, which makes it
pretty hard to hit. If you do manage to hit it, a full-page WAL record
is erroneously emitted for the unlogged index. If you then crash,
crash recovery will fail on that record with an error like this:
FATAL: could not create file "base/5/32819": File exists
Author: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/CALdSSPhpZXVFnWjwEBNcySx_vXtXHwB2g99gE6rK0uRJm-3GgQ@mail.gmail...
Backpatch-through: 14
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ab42568695c0ddb9f3d4c2fedcc003a8b8eb15f7
Modified Files
--------------
src/backend/access/brin/brin_pageops.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2025-12-18 13:13 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-12-18 13:13 pgsql: Do not emit WAL for unlogged BRIN indexes Heikki Linnakangas <heikki.linnakangas@iki.fi>
2025-12-18 13:13 pgsql: Do not emit WAL for unlogged BRIN indexes Heikki Linnakangas <heikki.linnakangas@iki.fi>
2025-12-18 13:13 pgsql: Do not emit WAL for unlogged BRIN indexes Heikki Linnakangas <heikki.linnakangas@iki.fi>
2025-12-18 13:13 pgsql: Do not emit WAL for unlogged BRIN indexes Heikki Linnakangas <heikki.linnakangas@iki.fi>
2025-12-18 13:13 pgsql: Do not emit WAL for unlogged BRIN indexes Heikki Linnakangas <heikki.linnakangas@iki.fi>
2025-12-18 13:13 pgsql: Do not emit WAL for unlogged BRIN indexes Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox