pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. 3+ messages / 1 participants [nested] [flat]
* pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. @ 2025-12-18 18:25 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2025-12-18 18:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. Commit 0decd5e89db9f5edb9b27351082f0d74aae7a9b6 missed DO_SUBSCRIPTION_REL, leading to assertion failures. In the unlikely use case of diffing "pg_dump --binary-upgrade" output, spurious diffs were possible. As part of fixing that, align the DumpableObject naming and sort order with DO_PUBLICATION_REL. The overall effect of this commit is to change sort order from (subname, srsubid) to (rel, subname). Since DO_SUBSCRIPTION_REL is only for --binary-upgrade, accept that larger-than-usual dump order change. Back-patch to v17, where commit 9a17be1e244a45a77de25ed2ada246fd34e4557d introduced DO_SUBSCRIPTION_REL. Reported-by: vignesh C <vignesh21@gmail.com> Author: vignesh C <vignesh21@gmail.com> Discussion: https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com Backpatch-through: 17 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/d49936f3028b0bb6ac8ff83e07e421ca2a4f5c3f Modified Files -------------- src/bin/pg_dump/pg_dump.c | 10 +++++----- src/bin/pg_dump/pg_dump_sort.c | 11 +++++++++++ src/bin/pg_upgrade/t/004_subscription.pl | 26 ++++++++++++++++---------- 3 files changed, 32 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. @ 2025-12-18 18:25 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2025-12-18 18:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. Commit 0decd5e89db9f5edb9b27351082f0d74aae7a9b6 missed DO_SUBSCRIPTION_REL, leading to assertion failures. In the unlikely use case of diffing "pg_dump --binary-upgrade" output, spurious diffs were possible. As part of fixing that, align the DumpableObject naming and sort order with DO_PUBLICATION_REL. The overall effect of this commit is to change sort order from (subname, srsubid) to (rel, subname). Since DO_SUBSCRIPTION_REL is only for --binary-upgrade, accept that larger-than-usual dump order change. Back-patch to v17, where commit 9a17be1e244a45a77de25ed2ada246fd34e4557d introduced DO_SUBSCRIPTION_REL. Reported-by: vignesh C <vignesh21@gmail.com> Author: vignesh C <vignesh21@gmail.com> Discussion: https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com Backpatch-through: 17 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/573e679a26649e14742b4a7d19331bf8ced908ae Modified Files -------------- src/bin/pg_dump/pg_dump.c | 10 +++++----- src/bin/pg_dump/pg_dump_sort.c | 11 +++++++++++ src/bin/pg_upgrade/t/004_subscription.pl | 27 +++++++++++++++++---------- 3 files changed, 33 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. @ 2025-12-18 18:25 Noah Misch <noah@leadboat.com> 0 siblings, 0 replies; 3+ messages in thread From: Noah Misch @ 2025-12-18 18:25 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. Commit 0decd5e89db9f5edb9b27351082f0d74aae7a9b6 missed DO_SUBSCRIPTION_REL, leading to assertion failures. In the unlikely use case of diffing "pg_dump --binary-upgrade" output, spurious diffs were possible. As part of fixing that, align the DumpableObject naming and sort order with DO_PUBLICATION_REL. The overall effect of this commit is to change sort order from (subname, srsubid) to (rel, subname). Since DO_SUBSCRIPTION_REL is only for --binary-upgrade, accept that larger-than-usual dump order change. Back-patch to v17, where commit 9a17be1e244a45a77de25ed2ada246fd34e4557d introduced DO_SUBSCRIPTION_REL. Reported-by: vignesh C <vignesh21@gmail.com> Author: vignesh C <vignesh21@gmail.com> Discussion: https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com Backpatch-through: 17 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1cdc07ad5ae5a50443abed871bd304c0836eaa72 Modified Files -------------- src/bin/pg_dump/pg_dump.c | 10 +++++----- src/bin/pg_dump/pg_dump_sort.c | 11 +++++++++++ src/bin/pg_upgrade/t/004_subscription.pl | 27 +++++++++++++++++---------- 3 files changed, 33 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2025-12-18 18:25 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-18 18:25 pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. Noah Misch <noah@leadboat.com> 2025-12-18 18:25 pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. Noah Misch <noah@leadboat.com> 2025-12-18 18:25 pgsql: Sort DO_SUBSCRIPTION_REL dump objects independent of OIDs. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox