pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. 4+ messages / 1 participants [nested] [flat]
* pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. @ 2025-12-29 02:50 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-29 02:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Mkvcbuild.pm builds of test_cloexec.c. Mkvcbuild.pm scrapes Makefile contents, but couldn't understand the change made by commit bec2a0aa. Revealed by BF animal hamerkop in branch REL_16_STABLE. 1. It used += instead of =, which didn't match the pattern that Mkvcbuild.pm looks for. Drop the +. 2. Mkvcbuild.pm doesn't link PROGRAM executables with libpgport. Apply a local workaround to REL_16_STABLE only (later branches dropped Mkvcbuild.pm). Backpatch-through: 16 Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/175163.1766357334%40sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/45d92b76dc4ac31d44e46ca38bee12d5d8fac1f5 Modified Files -------------- src/test/modules/test_cloexec/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. @ 2025-12-29 02:50 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-29 02:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Mkvcbuild.pm builds of test_cloexec.c. Mkvcbuild.pm scrapes Makefile contents, but couldn't understand the change made by commit bec2a0aa. Revealed by BF animal hamerkop in branch REL_16_STABLE. 1. It used += instead of =, which didn't match the pattern that Mkvcbuild.pm looks for. Drop the +. 2. Mkvcbuild.pm doesn't link PROGRAM executables with libpgport. Apply a local workaround to REL_16_STABLE only (later branches dropped Mkvcbuild.pm). Backpatch-through: 16 Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/175163.1766357334%40sss.pgh.pa.us Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/4da5c33a3a046fc81a6b490568801c5739286936 Modified Files -------------- src/test/modules/test_cloexec/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. @ 2025-12-29 02:50 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-29 02:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Mkvcbuild.pm builds of test_cloexec.c. Mkvcbuild.pm scrapes Makefile contents, but couldn't understand the change made by commit bec2a0aa. Revealed by BF animal hamerkop in branch REL_16_STABLE. 1. It used += instead of =, which didn't match the pattern that Mkvcbuild.pm looks for. Drop the +. 2. Mkvcbuild.pm doesn't link PROGRAM executables with libpgport. Apply a local workaround to REL_16_STABLE only (later branches dropped Mkvcbuild.pm). Backpatch-through: 16 Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/175163.1766357334%40sss.pgh.pa.us Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b3c8119e28c0ba4ef9921c67ea0cd42341f355e3 Modified Files -------------- src/test/modules/test_cloexec/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. @ 2025-12-29 02:51 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-29 02:51 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix Mkvcbuild.pm builds of test_cloexec.c. Mkvcbuild.pm scrapes Makefile contents, but couldn't understand the change made by commit bec2a0aa. Revealed by BF animal hamerkop in branch REL_16_STABLE. 1. It used += instead of =, which didn't match the pattern that Mkvcbuild.pm looks for. Drop the +. 2. Mkvcbuild.pm doesn't link PROGRAM executables with libpgport. Apply a local workaround to REL_16_STABLE only (later branches dropped Mkvcbuild.pm). Backpatch-through: 16 Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/175163.1766357334%40sss.pgh.pa.us Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/80e8ec772bff93e04f6cafe20bdf142bfa8c79de Modified Files -------------- src/test/modules/test_cloexec/Makefile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-12-29 02:51 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-29 02:50 pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. Thomas Munro <tmunro@postgresql.org> 2025-12-29 02:50 pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. Thomas Munro <tmunro@postgresql.org> 2025-12-29 02:50 pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. Thomas Munro <tmunro@postgresql.org> 2025-12-29 02:51 pgsql: Fix Mkvcbuild.pm builds of test_cloexec.c. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox