pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix macro name for io_uring_queue_init_mem check. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix macro name for io_uring_queue_init_mem check. @ 2025-12-31 19:19 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Masahiko Sawada @ 2025-12-31 19:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix macro name for io_uring_queue_init_mem check. Commit f54af9f2679d added a check for io_uring_queue_init_mem(). However, it used the macro name HAVE_LIBURING_QUEUE_INIT_MEM in both meson.build and the C code, while the Autotools build script defined HAVE_IO_URING_QUEUE_INIT_MEM. As a result, the optimization was never enabled in builds configured with Autotools, as the C code checked for the wrong macro name. This commit changes the macro name to HAVE_IO_URING_QUEUE_INIT_MEM in meson.build and the C code. This matches the actual function name (io_uring_queue_init_mem), following the standard HAVE_<FUNCTION> convention. Backpatch to 18, where the macro was introduced. Bug: #19368 Reported-by: Evan Si <evsi@amazon.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19368-016d79a7f3a1c599@postgresql.org Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/85d5bd308bf5dc3068a4c28aa0f12cc22272f789 Modified Files -------------- meson.build | 2 +- src/backend/storage/aio/method_io_uring.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix macro name for io_uring_queue_init_mem check. @ 2025-12-31 19:19 Masahiko Sawada <msawada@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Masahiko Sawada @ 2025-12-31 19:19 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix macro name for io_uring_queue_init_mem check. Commit f54af9f2679d added a check for io_uring_queue_init_mem(). However, it used the macro name HAVE_LIBURING_QUEUE_INIT_MEM in both meson.build and the C code, while the Autotools build script defined HAVE_IO_URING_QUEUE_INIT_MEM. As a result, the optimization was never enabled in builds configured with Autotools, as the C code checked for the wrong macro name. This commit changes the macro name to HAVE_IO_URING_QUEUE_INIT_MEM in meson.build and the C code. This matches the actual function name (io_uring_queue_init_mem), following the standard HAVE_<FUNCTION> convention. Backpatch to 18, where the macro was introduced. Bug: #19368 Reported-by: Evan Si <evsi@amazon.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19368-016d79a7f3a1c599@postgresql.org Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/640772c6df2bdb3e2b905b03ac199ae46e29cda3 Modified Files -------------- meson.build | 2 +- src/backend/storage/aio/method_io_uring.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-12-31 19:19 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-31 19:19 pgsql: Fix macro name for io_uring_queue_init_mem check. Masahiko Sawada <msawada@postgresql.org> 2025-12-31 19:19 pgsql: Fix macro name for io_uring_queue_init_mem check. Masahiko Sawada <msawada@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox