pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
5+ messages / 1 participants
[nested] [flat]
* pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
@ 2026-01-06 02:59 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2026-01-06 02:59 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
Prior to v15, GUC settings supplied in the CONNECTION clause of
CREATE SUBSCRIPTION were correctly passed through to
the publisher's walsender. For example:
CREATE SUBSCRIPTION mysub
CONNECTION 'options=''-c wal_sender_timeout=1000'''
PUBLICATION ...
would cause wal_sender_timeout to take effect on the publisher's walsender.
However, commit f3d4019da5d changed the way logical replication
connections are established, forcing the publisher's relevant
GUC settings (datestyle, intervalstyle, extra_float_digits) to
override those provided in the CONNECTION string. As a result,
from v15 through v18, GUC settings in the CONNECTION string were
always ignored.
This regression prevented per-connection tuning of logical replication.
For example, using a shorter timeout for walsender connecting
to a nearby subscriber and a longer one for walsender connecting
to a remote subscriber.
This commit restores the intended behavior by ensuring that
GUC settings in the CONNECTION string are again passed through
and applied by the walsender, allowing per-connection configuration.
Backpatch to v15, where the regression was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com
Backpatch-through: 15
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d926462d8190a81cc1f39c7fce65055f329e9419
Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 43 +++++++++++++++++-----
1 file changed, 34 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
@ 2026-01-06 02:59 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2026-01-06 02:59 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
Prior to v15, GUC settings supplied in the CONNECTION clause of
CREATE SUBSCRIPTION were correctly passed through to
the publisher's walsender. For example:
CREATE SUBSCRIPTION mysub
CONNECTION 'options=''-c wal_sender_timeout=1000'''
PUBLICATION ...
would cause wal_sender_timeout to take effect on the publisher's walsender.
However, commit f3d4019da5d changed the way logical replication
connections are established, forcing the publisher's relevant
GUC settings (datestyle, intervalstyle, extra_float_digits) to
override those provided in the CONNECTION string. As a result,
from v15 through v18, GUC settings in the CONNECTION string were
always ignored.
This regression prevented per-connection tuning of logical replication.
For example, using a shorter timeout for walsender connecting
to a nearby subscriber and a longer one for walsender connecting
to a remote subscriber.
This commit restores the intended behavior by ensuring that
GUC settings in the CONNECTION string are again passed through
and applied by the walsender, allowing per-connection configuration.
Backpatch to v15, where the regression was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/797fc5d1b38dd46f46d8482bfe762f5d5ca6a001
Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 43 +++++++++++++++++-----
1 file changed, 34 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
@ 2026-01-06 02:59 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2026-01-06 02:59 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
Prior to v15, GUC settings supplied in the CONNECTION clause of
CREATE SUBSCRIPTION were correctly passed through to
the publisher's walsender. For example:
CREATE SUBSCRIPTION mysub
CONNECTION 'options=''-c wal_sender_timeout=1000'''
PUBLICATION ...
would cause wal_sender_timeout to take effect on the publisher's walsender.
However, commit f3d4019da5d changed the way logical replication
connections are established, forcing the publisher's relevant
GUC settings (datestyle, intervalstyle, extra_float_digits) to
override those provided in the CONNECTION string. As a result,
from v15 through v18, GUC settings in the CONNECTION string were
always ignored.
This regression prevented per-connection tuning of logical replication.
For example, using a shorter timeout for walsender connecting
to a nearby subscriber and a longer one for walsender connecting
to a remote subscriber.
This commit restores the intended behavior by ensuring that
GUC settings in the CONNECTION string are again passed through
and applied by the walsender, allowing per-connection configuration.
Backpatch to v15, where the regression was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7a990e801a72fa438365532b8ebdfd88f250a6bf
Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 43 +++++++++++++++++-----
1 file changed, 34 insertions(+), 9 deletions(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
@ 2026-01-06 02:59 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2026-01-06 02:59 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
Prior to v15, GUC settings supplied in the CONNECTION clause of
CREATE SUBSCRIPTION were correctly passed through to
the publisher's walsender. For example:
CREATE SUBSCRIPTION mysub
CONNECTION 'options=''-c wal_sender_timeout=1000'''
PUBLICATION ...
would cause wal_sender_timeout to take effect on the publisher's walsender.
However, commit f3d4019da5d changed the way logical replication
connections are established, forcing the publisher's relevant
GUC settings (datestyle, intervalstyle, extra_float_digits) to
override those provided in the CONNECTION string. As a result,
from v15 through v18, GUC settings in the CONNECTION string were
always ignored.
This regression prevented per-connection tuning of logical replication.
For example, using a shorter timeout for walsender connecting
to a nearby subscriber and a longer one for walsender connecting
to a remote subscriber.
This commit restores the intended behavior by ensuring that
GUC settings in the CONNECTION string are again passed through
and applied by the walsender, allowing per-connection configuration.
Backpatch to v15, where the regression was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/75f3428f2436614f696c2e28ab3dde57830cad7d
Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 61 +++++++++++++++++++++-
1 file changed, 60 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
@ 2026-01-06 03:00 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 5+ messages in thread
From: Fujii Masao @ 2026-01-06 03:00 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION.
Prior to v15, GUC settings supplied in the CONNECTION clause of
CREATE SUBSCRIPTION were correctly passed through to
the publisher's walsender. For example:
CREATE SUBSCRIPTION mysub
CONNECTION 'options=''-c wal_sender_timeout=1000'''
PUBLICATION ...
would cause wal_sender_timeout to take effect on the publisher's walsender.
However, commit f3d4019da5d changed the way logical replication
connections are established, forcing the publisher's relevant
GUC settings (datestyle, intervalstyle, extra_float_digits) to
override those provided in the CONNECTION string. As a result,
from v15 through v18, GUC settings in the CONNECTION string were
always ignored.
This regression prevented per-connection tuning of logical replication.
For example, using a shorter timeout for walsender connecting
to a nearby subscriber and a longer one for walsender connecting
to a remote subscriber.
This commit restores the intended behavior by ensuring that
GUC settings in the CONNECTION string are again passed through
and applied by the walsender, allowing per-connection configuration.
Backpatch to v15, where the regression was introduced.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Chao Li <lic@highgo.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Japin Li <japinli@hotmail.com>
Discussion: https://postgr.es/m/CAHGQGwGYV+-abbKwdrM2UHUe-JYOFWmsrs6=QicyJO-j+-Widw@mail.gmail.com
Backpatch-through: 15
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f7eb44e0f0871e13188f50b0f21d52c10337a60a
Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 61 +++++++++++++++++++++-
1 file changed, 60 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-01-06 03:00 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-01-06 02:59 pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Fujii Masao <fujii@postgresql.org>
2026-01-06 02:59 pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Fujii Masao <fujii@postgresql.org>
2026-01-06 02:59 pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Fujii Masao <fujii@postgresql.org>
2026-01-06 02:59 pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Fujii Masao <fujii@postgresql.org>
2026-01-06 03:00 pgsql: Honor GUC settings specified in CREATE SUBSCRIPTION CONNECTION. Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox