pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Update comments atop ReplicationSlotCreate. 2+ messages / 1 participants [nested] [flat]
* pgsql: Update comments atop ReplicationSlotCreate. @ 2026-01-06 05:11 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2026-01-06 05:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Update comments atop ReplicationSlotCreate. Since commit 1462aad2e4, which introduced the ability to modify the two_phase property of a slot, the comments above ReplicationSlotCreate have become outdated. We have now added a cautionary note in the comments above ReplicationSlotAlter explaining when it is safe to modify the two_phase property of a slot. Author: Daniil Davydov <3danissimo@gmail.com> Author: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com> Backpatch-through: 18 Discussion: https://postgr.es/m/CAJDiXggZXQZ7bD0QcTizDt6us9aX6ZKK4dWxzgb5x3+TsVHjqQ@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c970bdc037f4f35f1ff852b4c032f5fb3f6f6622 Modified Files -------------- src/backend/replication/slot.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Update comments atop ReplicationSlotCreate. @ 2026-01-06 05:11 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2026-01-06 05:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Update comments atop ReplicationSlotCreate. Since commit 1462aad2e4, which introduced the ability to modify the two_phase property of a slot, the comments above ReplicationSlotCreate have become outdated. We have now added a cautionary note in the comments above ReplicationSlotAlter explaining when it is safe to modify the two_phase property of a slot. Author: Daniil Davydov <3danissimo@gmail.com> Author: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com> Backpatch-through: 18 Discussion: https://postgr.es/m/CAJDiXggZXQZ7bD0QcTizDt6us9aX6ZKK4dWxzgb5x3+TsVHjqQ@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/aa40615cc99211db70429ebbc4c8a1549dcc06ae Modified Files -------------- src/backend/replication/slot.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-01-06 05:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-01-06 05:11 pgsql: Update comments atop ReplicationSlotCreate. Amit Kapila <akapila@postgresql.org> 2026-01-06 05:11 pgsql: Update comments atop ReplicationSlotCreate. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox