pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_waldump: Relax LSN comparison check in TAP test 4+ messages / 1 participants [nested] [flat]
* pgsql: pg_waldump: Relax LSN comparison check in TAP test @ 2026-01-14 07:03 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-01-14 07:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_waldump: Relax LSN comparison check in TAP test The test 002_save_fullpage.pl, checking --save-fullpage fails with wal_consistency_checking enabled, due to the fact that the block saved in the file has the same LSN as the LSN used in the file name. The test required that the block LSN is stritly lower than file LSN. This commit relaxes the check a bit, by allowing the LSNs to match. While on it, the test name is reworded to include some information about the file and block LSNs, which is useful for debugging. Author: Andrey Borodin <x4mmm@yandex-team.ru> Discussion: https://postgr.es/m/4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru Backpatch-through: 16 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/64893323925322d2236aaac111343768cf7dafa0 Modified Files -------------- src/bin/pg_waldump/t/002_save_fullpage.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: pg_waldump: Relax LSN comparison check in TAP test @ 2026-01-14 07:03 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-01-14 07:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_waldump: Relax LSN comparison check in TAP test The test 002_save_fullpage.pl, checking --save-fullpage fails with wal_consistency_checking enabled, due to the fact that the block saved in the file has the same LSN as the LSN used in the file name. The test required that the block LSN is stritly lower than file LSN. This commit relaxes the check a bit, by allowing the LSNs to match. While on it, the test name is reworded to include some information about the file and block LSNs, which is useful for debugging. Author: Andrey Borodin <x4mmm@yandex-team.ru> Discussion: https://postgr.es/m/4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru Backpatch-through: 16 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a244e17077301ec3c32d0eaf6f8d72b0132791fb Modified Files -------------- src/bin/pg_waldump/t/002_save_fullpage.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: pg_waldump: Relax LSN comparison check in TAP test @ 2026-01-14 07:03 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-01-14 07:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_waldump: Relax LSN comparison check in TAP test The test 002_save_fullpage.pl, checking --save-fullpage fails with wal_consistency_checking enabled, due to the fact that the block saved in the file has the same LSN as the LSN used in the file name. The test required that the block LSN is stritly lower than file LSN. This commit relaxes the check a bit, by allowing the LSNs to match. While on it, the test name is reworded to include some information about the file and block LSNs, which is useful for debugging. Author: Andrey Borodin <x4mmm@yandex-team.ru> Discussion: https://postgr.es/m/4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru Backpatch-through: 16 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2170e52193c6f02ddb915f833f269714c9c40eae Modified Files -------------- src/bin/pg_waldump/t/002_save_fullpage.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: pg_waldump: Relax LSN comparison check in TAP test @ 2026-01-14 07:03 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 4+ messages in thread From: Michael Paquier @ 2026-01-14 07:03 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_waldump: Relax LSN comparison check in TAP test The test 002_save_fullpage.pl, checking --save-fullpage fails with wal_consistency_checking enabled, due to the fact that the block saved in the file has the same LSN as the LSN used in the file name. The test required that the block LSN is stritly lower than file LSN. This commit relaxes the check a bit, by allowing the LSNs to match. While on it, the test name is reworded to include some information about the file and block LSNs, which is useful for debugging. Author: Andrey Borodin <x4mmm@yandex-team.ru> Discussion: https://postgr.es/m/4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru Backpatch-through: 16 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/4fe1ea7777c8161c655364345d0429cf74f21db4 Modified Files -------------- src/bin/pg_waldump/t/002_save_fullpage.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-01-14 07:03 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-01-14 07:03 pgsql: pg_waldump: Relax LSN comparison check in TAP test Michael Paquier <michael@paquier.xyz> 2026-01-14 07:03 pgsql: pg_waldump: Relax LSN comparison check in TAP test Michael Paquier <michael@paquier.xyz> 2026-01-14 07:03 pgsql: pg_waldump: Relax LSN comparison check in TAP test Michael Paquier <michael@paquier.xyz> 2026-01-14 07:03 pgsql: pg_waldump: Relax LSN comparison check in TAP test Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox