pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: pg_stat_statements: Fix crash in list squashing with Vars 2+ messages / 1 participants [nested] [flat]
* pgsql: pg_stat_statements: Fix crash in list squashing with Vars @ 2026-01-19 23:11 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2026-01-19 23:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_stat_statements: Fix crash in list squashing with Vars When IN/ANY clauses contain both constants and variable expressions, the optimizer transforms them into separate structures: constants become an array expression while variables become individual OR conditions. This transformation was creating an overlap with the token locations, causing pg_stat_statements query normalization to crash because it could not calculate the amount of bytes remaining to write for the normalized query. This commit disables squashing for mixed IN list expressions when constructing a scalar array op, by setting list_start and list_end to -1 when both variables and non-variables are present. Some regression tests are added to PGSS to verify these patterns. Author: Sami Imseih <samimseih@gmail.com> Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com> Discussion: https://postgr.es/m/CAA5RZ0ts9qiONnHjjHxPxtePs22GBo4d3jZ_s2BQC59AN7XbAA@mail.gmail.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/5d95219faa1a95b78202be9e25bdb2aeb30cb4dc Modified Files -------------- contrib/pg_stat_statements/expected/squashing.out | 22 +++++++++++++++++++++- contrib/pg_stat_statements/sql/squashing.sql | 6 ++++++ src/backend/parser/parse_expr.c | 13 +++++++++++-- 3 files changed, 38 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: pg_stat_statements: Fix crash in list squashing with Vars @ 2026-01-19 23:11 Michael Paquier <michael@paquier.xyz> 0 siblings, 0 replies; 2+ messages in thread From: Michael Paquier @ 2026-01-19 23:11 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org pg_stat_statements: Fix crash in list squashing with Vars When IN/ANY clauses contain both constants and variable expressions, the optimizer transforms them into separate structures: constants become an array expression while variables become individual OR conditions. This transformation was creating an overlap with the token locations, causing pg_stat_statements query normalization to crash because it could not calculate the amount of bytes remaining to write for the normalized query. This commit disables squashing for mixed IN list expressions when constructing a scalar array op, by setting list_start and list_end to -1 when both variables and non-variables are present. Some regression tests are added to PGSS to verify these patterns. Author: Sami Imseih <samimseih@gmail.com> Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com> Discussion: https://postgr.es/m/CAA5RZ0ts9qiONnHjjHxPxtePs22GBo4d3jZ_s2BQC59AN7XbAA@mail.gmail.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3304e97b1b73e0ca7b14bbd8ed17162b3cb056ec Modified Files -------------- contrib/pg_stat_statements/expected/squashing.out | 22 +++++++++++++++++++++- contrib/pg_stat_statements/sql/squashing.sql | 6 ++++++ src/backend/parser/parse_expr.c | 13 +++++++++++-- 3 files changed, 38 insertions(+), 3 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-01-19 23:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-01-19 23:11 pgsql: pg_stat_statements: Fix crash in list squashing with Vars Michael Paquier <michael@paquier.xyz> 2026-01-19 23:11 pgsql: pg_stat_statements: Fix crash in list squashing with Vars Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox