pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: amcheck: Fix snapshot usage in bt_index_parent_check 9+ messages / 1 participants [nested] [flat]
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2025-12-04 17:12 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2025-12-04 17:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. This problem came in with commit 5ae2087202af, which introduced uniqueness check. Backpatch to 17. Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6bd469d26aca6ea413b35bfcb611dfa3a8f5ea45 Modified Files -------------- contrib/amcheck/t/002_cic.pl | 23 +++++++++++ contrib/amcheck/verify_nbtree.c | 86 +++++++++++++++++------------------------ doc/src/sgml/amcheck.sgml | 2 +- 3 files changed, 60 insertions(+), 51 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2025-12-04 17:12 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2025-12-04 17:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. This problem came in with commit 5ae2087202af, which introduced uniqueness check. Backpatch to 17. Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/df93f94dda51cae1d81526472e41bbde0a089377 Modified Files -------------- contrib/amcheck/t/002_cic.pl | 23 +++++++++++ contrib/amcheck/verify_nbtree.c | 86 +++++++++++++++++------------------------ doc/src/sgml/amcheck.sgml | 2 +- 3 files changed, 60 insertions(+), 51 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2025-12-04 17:12 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2025-12-04 17:12 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. This problem came in with commit 5ae2087202af, which introduced uniqueness check. Backpatch to 17. Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ce2f575b7cf4ac9dbebed4df226b7de64c7d340d Modified Files -------------- contrib/amcheck/t/002_cic.pl | 23 +++++++++++ contrib/amcheck/verify_nbtree.c | 86 +++++++++++++++++------------------------ doc/src/sgml/amcheck.sgml | 2 +- 3 files changed, 60 insertions(+), 51 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2026-01-21 17:56 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2026-01-21 17:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <donghanglin@gmail.com> Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/1f28982e409451249646910e585469076c43ba8f Modified Files -------------- contrib/amcheck/t/002_cic.pl | 3 ++- contrib/amcheck/verify_nbtree.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2026-01-21 17:56 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2026-01-21 17:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <donghanglin@gmail.com> Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/3c83a2a0ace90a83249a51925706395c76a85bdf Modified Files -------------- contrib/amcheck/t/002_cic.pl | 3 ++- contrib/amcheck/verify_nbtree.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2026-01-21 17:56 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2026-01-21 17:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <donghanglin@gmail.com> Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e1a327dc4dcbd6ecbc8b97b57a2ffdb20ca2e3f5 Modified Files -------------- contrib/amcheck/t/002_cic.pl | 3 ++- contrib/amcheck/verify_nbtree.c | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2026-01-21 17:56 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2026-01-21 17:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <donghanglin@gmail.com> Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/098a1fab8a9bfe2b37eda8d790efbc15c9bdf7bc Modified Files -------------- contrib/amcheck/t/002_cic.pl | 24 ++++++++++++++ contrib/amcheck/verify_nbtree.c | 69 ++++++++++++++++++----------------------- doc/src/sgml/amcheck.sgml | 2 +- 3 files changed, 56 insertions(+), 39 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2026-01-21 17:56 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2026-01-21 17:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <donghanglin@gmail.com> Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dcddd69871976aabf99039b72124cf9a67e86d0f Modified Files -------------- contrib/amcheck/t/002_cic.pl | 24 ++++++++++++++ contrib/amcheck/verify_nbtree.c | 69 ++++++++++++++++++----------------------- doc/src/sgml/amcheck.sgml | 2 +- 3 files changed, 56 insertions(+), 39 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
* pgsql: amcheck: Fix snapshot usage in bt_index_parent_check @ 2026-01-21 17:56 Álvaro Herrera <alvherre@kurilemu.de> 0 siblings, 0 replies; 9+ messages in thread From: Álvaro Herrera @ 2026-01-21 17:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org amcheck: Fix snapshot usage in bt_index_parent_check We were using SnapshotAny to do some index checks, but that's wrong and causes spurious errors when used on indexes created by CREATE INDEX CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it. Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not 5ae2087202af as claimed previously), so all live branches are affected. Also take the opportunity to fix some comments that we failed to update in the original commits and apply pgperltidy. In branch 14, remove the unnecessary test plan specification (which would have need to have been changed anyway; c.f. commit 549ec201d613.) Diagnosed-by: Donghang Lin <donghanglin@gmail.com> Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com> Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru> Backpatch-through: 17 Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/607a67c5e6575b3f2d6e19ce32e79c6f9d3fa5ef Modified Files -------------- contrib/amcheck/t/002_cic.pl | 26 +++++++++++++++- contrib/amcheck/verify_nbtree.c | 69 ++++++++++++++++++----------------------- doc/src/sgml/amcheck.sgml | 2 +- 3 files changed, 57 insertions(+), 40 deletions(-) ^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2026-01-21 17:56 UTC | newest] Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-04 17:12 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2025-12-04 17:12 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2025-12-04 17:12 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2026-01-21 17:56 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2026-01-21 17:56 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2026-01-21 17:56 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2026-01-21 17:56 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2026-01-21 17:56 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de> 2026-01-21 17:56 pgsql: amcheck: Fix snapshot usage in bt_index_parent_check Álvaro Herrera <alvherre@kurilemu.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox