pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix trigger transition table capture for MERGE in CTE queries. 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix trigger transition table capture for MERGE in CTE queries. @ 2026-01-24 11:36 Dean Rasheed <dean.a.rasheed@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Dean Rasheed @ 2026-01-24 11:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix trigger transition table capture for MERGE in CTE queries. When executing a data-modifying CTE query containing MERGE and some other DML operation on a table with statement-level AFTER triggers, the transition tables passed to the triggers would fail to include the rows affected by the MERGE. The reason is that, when initializing a ModifyTable node for MERGE, MakeTransitionCaptureState() would create a TransitionCaptureState structure with a single "tcs_private" field pointing to an AfterTriggersTableData structure with cmdType == CMD_MERGE. Tuples captured there would then not be included in the sets of tuples captured when executing INSERT/UPDATE/DELETE ModifyTable nodes in the same query. Since there are no MERGE triggers, we should only create AfterTriggersTableData structures for INSERT/UPDATE/DELETE. Individual MERGE actions should then use those, thereby sharing the same capture tuplestores as any other DML commands executed in the same query. This requires changing the TransitionCaptureState structure, replacing "tcs_private" with 3 separate pointers to AfterTriggersTableData structures, one for each of INSERT, UPDATE, and DELETE. Nominally, this is an ABI break to a public structure in commands/trigger.h. However, since this is a private field pointing to an opaque data structure, the only way to create a valid TransitionCaptureState is by calling MakeTransitionCaptureState(), and no extensions appear to be doing that anyway, so it seems safe for back-patching. Backpatch to v15, where MERGE was introduced. Bug: #19380 Reported-by: Daniel Woelfel <dwwoelfel@gmail.com> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19380-4e293be2b4007248%40postgresql.org Backpatch-through: 15 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c6ce4dcf9d3b7a8a89aca386124c473f98fc329e Modified Files -------------- src/backend/commands/trigger.c | 148 +++++++++++++++++++++------------ src/include/commands/trigger.h | 4 +- src/test/regress/expected/triggers.out | 8 +- src/test/regress/sql/triggers.sql | 4 + 4 files changed, 107 insertions(+), 57 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix trigger transition table capture for MERGE in CTE queries. @ 2026-01-24 11:36 Dean Rasheed <dean.a.rasheed@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Dean Rasheed @ 2026-01-24 11:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix trigger transition table capture for MERGE in CTE queries. When executing a data-modifying CTE query containing MERGE and some other DML operation on a table with statement-level AFTER triggers, the transition tables passed to the triggers would fail to include the rows affected by the MERGE. The reason is that, when initializing a ModifyTable node for MERGE, MakeTransitionCaptureState() would create a TransitionCaptureState structure with a single "tcs_private" field pointing to an AfterTriggersTableData structure with cmdType == CMD_MERGE. Tuples captured there would then not be included in the sets of tuples captured when executing INSERT/UPDATE/DELETE ModifyTable nodes in the same query. Since there are no MERGE triggers, we should only create AfterTriggersTableData structures for INSERT/UPDATE/DELETE. Individual MERGE actions should then use those, thereby sharing the same capture tuplestores as any other DML commands executed in the same query. This requires changing the TransitionCaptureState structure, replacing "tcs_private" with 3 separate pointers to AfterTriggersTableData structures, one for each of INSERT, UPDATE, and DELETE. Nominally, this is an ABI break to a public structure in commands/trigger.h. However, since this is a private field pointing to an opaque data structure, the only way to create a valid TransitionCaptureState is by calling MakeTransitionCaptureState(), and no extensions appear to be doing that anyway, so it seems safe for back-patching. Backpatch to v15, where MERGE was introduced. Bug: #19380 Reported-by: Daniel Woelfel <dwwoelfel@gmail.com> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19380-4e293be2b4007248%40postgresql.org Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c5824536e7ca3c5ef5a9db59bd36c4e6beb23f51 Modified Files -------------- src/backend/commands/trigger.c | 148 +++++++++++++++++++++------------ src/include/commands/trigger.h | 4 +- src/test/regress/expected/triggers.out | 8 +- src/test/regress/sql/triggers.sql | 4 + 4 files changed, 107 insertions(+), 57 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix trigger transition table capture for MERGE in CTE queries. @ 2026-01-24 11:36 Dean Rasheed <dean.a.rasheed@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Dean Rasheed @ 2026-01-24 11:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix trigger transition table capture for MERGE in CTE queries. When executing a data-modifying CTE query containing MERGE and some other DML operation on a table with statement-level AFTER triggers, the transition tables passed to the triggers would fail to include the rows affected by the MERGE. The reason is that, when initializing a ModifyTable node for MERGE, MakeTransitionCaptureState() would create a TransitionCaptureState structure with a single "tcs_private" field pointing to an AfterTriggersTableData structure with cmdType == CMD_MERGE. Tuples captured there would then not be included in the sets of tuples captured when executing INSERT/UPDATE/DELETE ModifyTable nodes in the same query. Since there are no MERGE triggers, we should only create AfterTriggersTableData structures for INSERT/UPDATE/DELETE. Individual MERGE actions should then use those, thereby sharing the same capture tuplestores as any other DML commands executed in the same query. This requires changing the TransitionCaptureState structure, replacing "tcs_private" with 3 separate pointers to AfterTriggersTableData structures, one for each of INSERT, UPDATE, and DELETE. Nominally, this is an ABI break to a public structure in commands/trigger.h. However, since this is a private field pointing to an opaque data structure, the only way to create a valid TransitionCaptureState is by calling MakeTransitionCaptureState(), and no extensions appear to be doing that anyway, so it seems safe for back-patching. Backpatch to v15, where MERGE was introduced. Bug: #19380 Reported-by: Daniel Woelfel <dwwoelfel@gmail.com> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19380-4e293be2b4007248%40postgresql.org Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e7391bbf14db94afee1fd3c011314f7b8ee493e9 Modified Files -------------- src/backend/commands/trigger.c | 148 +++++++++++++++++++++------------ src/include/commands/trigger.h | 4 +- src/test/regress/expected/triggers.out | 8 +- src/test/regress/sql/triggers.sql | 4 + 4 files changed, 107 insertions(+), 57 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix trigger transition table capture for MERGE in CTE queries. @ 2026-01-24 11:36 Dean Rasheed <dean.a.rasheed@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Dean Rasheed @ 2026-01-24 11:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix trigger transition table capture for MERGE in CTE queries. When executing a data-modifying CTE query containing MERGE and some other DML operation on a table with statement-level AFTER triggers, the transition tables passed to the triggers would fail to include the rows affected by the MERGE. The reason is that, when initializing a ModifyTable node for MERGE, MakeTransitionCaptureState() would create a TransitionCaptureState structure with a single "tcs_private" field pointing to an AfterTriggersTableData structure with cmdType == CMD_MERGE. Tuples captured there would then not be included in the sets of tuples captured when executing INSERT/UPDATE/DELETE ModifyTable nodes in the same query. Since there are no MERGE triggers, we should only create AfterTriggersTableData structures for INSERT/UPDATE/DELETE. Individual MERGE actions should then use those, thereby sharing the same capture tuplestores as any other DML commands executed in the same query. This requires changing the TransitionCaptureState structure, replacing "tcs_private" with 3 separate pointers to AfterTriggersTableData structures, one for each of INSERT, UPDATE, and DELETE. Nominally, this is an ABI break to a public structure in commands/trigger.h. However, since this is a private field pointing to an opaque data structure, the only way to create a valid TransitionCaptureState is by calling MakeTransitionCaptureState(), and no extensions appear to be doing that anyway, so it seems safe for back-patching. Backpatch to v15, where MERGE was introduced. Bug: #19380 Reported-by: Daniel Woelfel <dwwoelfel@gmail.com> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19380-4e293be2b4007248%40postgresql.org Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b4307ae2e540847f84147d45b258440eaf570536 Modified Files -------------- src/backend/commands/trigger.c | 148 +++++++++++++++++++++------------ src/include/commands/trigger.h | 4 +- src/test/regress/expected/triggers.out | 8 +- src/test/regress/sql/triggers.sql | 4 + 4 files changed, 107 insertions(+), 57 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix trigger transition table capture for MERGE in CTE queries. @ 2026-01-24 11:36 Dean Rasheed <dean.a.rasheed@gmail.com> 0 siblings, 0 replies; 5+ messages in thread From: Dean Rasheed @ 2026-01-24 11:36 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix trigger transition table capture for MERGE in CTE queries. When executing a data-modifying CTE query containing MERGE and some other DML operation on a table with statement-level AFTER triggers, the transition tables passed to the triggers would fail to include the rows affected by the MERGE. The reason is that, when initializing a ModifyTable node for MERGE, MakeTransitionCaptureState() would create a TransitionCaptureState structure with a single "tcs_private" field pointing to an AfterTriggersTableData structure with cmdType == CMD_MERGE. Tuples captured there would then not be included in the sets of tuples captured when executing INSERT/UPDATE/DELETE ModifyTable nodes in the same query. Since there are no MERGE triggers, we should only create AfterTriggersTableData structures for INSERT/UPDATE/DELETE. Individual MERGE actions should then use those, thereby sharing the same capture tuplestores as any other DML commands executed in the same query. This requires changing the TransitionCaptureState structure, replacing "tcs_private" with 3 separate pointers to AfterTriggersTableData structures, one for each of INSERT, UPDATE, and DELETE. Nominally, this is an ABI break to a public structure in commands/trigger.h. However, since this is a private field pointing to an opaque data structure, the only way to create a valid TransitionCaptureState is by calling MakeTransitionCaptureState(), and no extensions appear to be doing that anyway, so it seems safe for back-patching. Backpatch to v15, where MERGE was introduced. Bug: #19380 Reported-by: Daniel Woelfel <dwwoelfel@gmail.com> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19380-4e293be2b4007248%40postgresql.org Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c5fc17ddaccff14bc22217df2b06ed43a5af16ba Modified Files -------------- src/backend/commands/trigger.c | 148 +++++++++++++++++++++------------ src/include/commands/trigger.h | 4 +- src/test/regress/expected/triggers.out | 8 +- src/test/regress/sql/triggers.sql | 4 + 4 files changed, 107 insertions(+), 57 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-01-24 11:36 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-01-24 11:36 pgsql: Fix trigger transition table capture for MERGE in CTE queries. Dean Rasheed <dean.a.rasheed@gmail.com> 2026-01-24 11:36 pgsql: Fix trigger transition table capture for MERGE in CTE queries. Dean Rasheed <dean.a.rasheed@gmail.com> 2026-01-24 11:36 pgsql: Fix trigger transition table capture for MERGE in CTE queries. Dean Rasheed <dean.a.rasheed@gmail.com> 2026-01-24 11:36 pgsql: Fix trigger transition table capture for MERGE in CTE queries. Dean Rasheed <dean.a.rasheed@gmail.com> 2026-01-24 11:36 pgsql: Fix trigger transition table capture for MERGE in CTE queries. Dean Rasheed <dean.a.rasheed@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox