pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feed[PATCH] Fix flag tests in src/test/modules/test_oat_hooks
2+ messages / 2 participants
[nested] [flat]
* [PATCH] Fix flag tests in src/test/modules/test_oat_hooks
@ 2022-07-12 15:18 Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 0 replies; 2+ messages in thread
From: Alvaro Herrera @ 2022-07-12 15:18 UTC (permalink / raw)
In what must have been a copy'n paste mistake, all the flag tests use
the same flag rather than a different flag each. The bug is not
suprising, considering that it's dead code.
---
src/test/modules/test_oat_hooks/test_oat_hooks.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
inline patch 1: src/test/modules/test_oat_hooks/test_oat_hooks.c (+5/-5 lines) download inline-1.patch
diff --git a/src/test/modules/test_oat_hooks/test_oat_hooks.c b/src/test/modules/test_oat_hooks/test_oat_hooks.c
index 1f40d632e0..900d597f5d 100644
--- a/src/test/modules/test_oat_hooks/test_oat_hooks.c
+++ b/src/test/modules/test_oat_hooks/test_oat_hooks.c
@@ -1795,15 +1795,15 @@ accesstype_arg_to_string(ObjectAccessType access, void *arg)
return psprintf("%s%s%s%s%s%s",
((drop_arg->dropflags & PERFORM_DELETION_INTERNAL)
? "internal action," : ""),
- ((drop_arg->dropflags & PERFORM_DELETION_INTERNAL)
+ ((drop_arg->dropflags & PERFORM_DELETION_CONCURRENTLY)
? "concurrent drop," : ""),
- ((drop_arg->dropflags & PERFORM_DELETION_INTERNAL)
+ ((drop_arg->dropflags & PERFORM_DELETION_QUIETLY)
? "suppress notices," : ""),
- ((drop_arg->dropflags & PERFORM_DELETION_INTERNAL)
+ ((drop_arg->dropflags & PERFORM_DELETION_SKIP_ORIGINAL)
? "keep original object," : ""),
- ((drop_arg->dropflags & PERFORM_DELETION_INTERNAL)
+ ((drop_arg->dropflags & PERFORM_DELETION_SKIP_EXTENSIONS)
? "keep extensions," : ""),
- ((drop_arg->dropflags & PERFORM_DELETION_INTERNAL)
+ ((drop_arg->dropflags & PERFORM_DELETION_CONCURRENT_LOCK)
? "normal concurrent drop," : ""));
}
break;
--
2.30.2
* pgsql: Remove unnecessary abort() from WalSndShutdown().
@ 2026-01-27 02:56 Fujii Masao <fujii@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Fujii Masao @ 2026-01-27 02:56 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove unnecessary abort() from WalSndShutdown().
WalSndShutdown() previously called abort() after proc_exit(0) to
silence compiler warnings. This is no longer needed, because both
WalSndShutdown() and proc_exit() are declared pg_noreturn,
allowing the compiler to recognize that the function does not return.
Also there are already other functions, such as CheckpointerMain(),
that call proc_exit() without an abort(), and they do not produce warnings.
Therefore this abort() call in WalSndShutdown() is useless and
this commit removes it.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Discussion: https://postgr.es/m/CAHGQGwHPX1yoixq+YB5rF4zL90TMmSEa3FpHURtqW3Jc5+=oSA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1ea44d7ddfb6ebacb6fb8ae2f5d6e904b2394f29
Modified Files
--------------
src/backend/replication/walsender.c | 1 -
1 file changed, 1 deletion(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-01-27 02:56 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 15:18 [PATCH] Fix flag tests in src/test/modules/test_oat_hooks Alvaro Herrera <alvherre@alvh.no-ip.org>
2026-01-27 02:56 pgsql: Remove unnecessary abort() from WalSndShutdown(). Fujii Masao <fujii@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox