pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix theoretical memory leaks in pg_locale_libc.c. 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix theoretical memory leaks in pg_locale_libc.c. @ 2026-01-29 18:26 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-01-29 18:26 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix theoretical memory leaks in pg_locale_libc.c. The leaks were hard to reach in practice and the impact was low. The callers provide a buffer the same number of bytes as the source string (plus one for NUL terminator) as a starting size, and libc never increases the number of characters. But, if the byte length of one of the converted characters is larger, then it might need a larger destination buffer. Previously, in that case, the working buffers would be leaked. Even in that case, the call typically happens within a context that will soon be reset. Regardless, it's worth fixing to avoid such assumptions, and the fix is simple so it's worth backporting. Discussion: https://postgr.es/m/e2b7a0a88aaadded7e2d19f42d5ab03c9e182ad8.camel@j-davis.com Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/de90bb7db1f8c7ab1289f82f877a6e18f7b3d468 Modified Files -------------- src/backend/utils/adt/pg_locale_libc.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix theoretical memory leaks in pg_locale_libc.c. @ 2026-01-29 18:27 Jeff Davis <jdavis@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Jeff Davis @ 2026-01-29 18:27 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix theoretical memory leaks in pg_locale_libc.c. The leaks were hard to reach in practice and the impact was low. The callers provide a buffer the same number of bytes as the source string (plus one for NUL terminator) as a starting size, and libc never increases the number of characters. But, if the byte length of one of the converted characters is larger, then it might need a larger destination buffer. Previously, in that case, the working buffers would be leaked. Even in that case, the call typically happens within a context that will soon be reset. Regardless, it's worth fixing to avoid such assumptions, and the fix is simple so it's worth backporting. Discussion: https://postgr.es/m/e2b7a0a88aaadded7e2d19f42d5ab03c9e182ad8.camel@j-davis.com Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/09d8c351744d3fdc7e1f72ab3a3b08b25e0c36f1 Modified Files -------------- src/backend/utils/adt/pg_locale_libc.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-01-29 18:27 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-01-29 18:26 pgsql: Fix theoretical memory leaks in pg_locale_libc.c. Jeff Davis <jdavis@postgresql.org> 2026-01-29 18:27 pgsql: Fix theoretical memory leaks in pg_locale_libc.c. Jeff Davis <jdavis@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox