public inbox for [email protected]help / color / mirror / Atom feed
pgsql: Fix logical replication TAP test to read publisher log correctly 5+ messages / 1 participants [nested] [flat]
* pgsql: Fix logical replication TAP test to read publisher log correctly @ 2026-02-04 15:48 Fujii Masao <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Fujii Masao @ 2026-02-04 15:48 UTC (permalink / raw) To: [email protected] Fix logical replication TAP test to read publisher log correctly. Commit 5f13999aa11 added a TAP test for GUC settings passed via the CONNECTION string in logical replication, but the buildfarm member sungazer reported test failures. The test incorrectly used the subscriber's log file position as the starting offset when reading the publisher's log. As a result, the test failed to find the expected log message in the publisher's log and erroneously reported a failure. This commit fixes the test to use the publisher's own log file position when reading the publisher's log. Also, to avoid similar confusion in the future, this commit splits the single $log_location variable into $log_location_pub and $log_location_sub, clearly distinguishing publisher and subscriber log positions. Backpatched to v15, where commit 5f13999aa11 introduced the test. Per buildfarm member sungazer. This issue was reported and diagnosed by Alexander Lakhin. Reported-by: Alexander Lakhin <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/36ead7123292c2849be9950f3e552325fad7e6b7 Modified Files -------------- src/test/subscription/t/001_rep_changes.pl | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix logical replication TAP test to read publisher log correctly @ 2026-02-04 15:48 Fujii Masao <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Fujii Masao @ 2026-02-04 15:48 UTC (permalink / raw) To: [email protected] Fix logical replication TAP test to read publisher log correctly. Commit 5f13999aa11 added a TAP test for GUC settings passed via the CONNECTION string in logical replication, but the buildfarm member sungazer reported test failures. The test incorrectly used the subscriber's log file position as the starting offset when reading the publisher's log. As a result, the test failed to find the expected log message in the publisher's log and erroneously reported a failure. This commit fixes the test to use the publisher's own log file position when reading the publisher's log. Also, to avoid similar confusion in the future, this commit splits the single $log_location variable into $log_location_pub and $log_location_sub, clearly distinguishing publisher and subscriber log positions. Backpatched to v15, where commit 5f13999aa11 introduced the test. Per buildfarm member sungazer. This issue was reported and diagnosed by Alexander Lakhin. Reported-by: Alexander Lakhin <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/8eb17e82fc1d12b2e897b0c053c7c5c003940833 Modified Files -------------- src/test/subscription/t/001_rep_changes.pl | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix logical replication TAP test to read publisher log correctly @ 2026-02-04 15:48 Fujii Masao <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Fujii Masao @ 2026-02-04 15:48 UTC (permalink / raw) To: [email protected] Fix logical replication TAP test to read publisher log correctly. Commit 5f13999aa11 added a TAP test for GUC settings passed via the CONNECTION string in logical replication, but the buildfarm member sungazer reported test failures. The test incorrectly used the subscriber's log file position as the starting offset when reading the publisher's log. As a result, the test failed to find the expected log message in the publisher's log and erroneously reported a failure. This commit fixes the test to use the publisher's own log file position when reading the publisher's log. Also, to avoid similar confusion in the future, this commit splits the single $log_location variable into $log_location_pub and $log_location_sub, clearly distinguishing publisher and subscriber log positions. Backpatched to v15, where commit 5f13999aa11 introduced the test. Per buildfarm member sungazer. This issue was reported and diagnosed by Alexander Lakhin. Reported-by: Alexander Lakhin <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c423bf63a096c47a2829f9c3edda5dde3426fdf6 Modified Files -------------- src/test/subscription/t/001_rep_changes.pl | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix logical replication TAP test to read publisher log correctly @ 2026-02-04 15:49 Fujii Masao <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Fujii Masao @ 2026-02-04 15:49 UTC (permalink / raw) To: [email protected] Fix logical replication TAP test to read publisher log correctly. Commit 5f13999aa11 added a TAP test for GUC settings passed via the CONNECTION string in logical replication, but the buildfarm member sungazer reported test failures. The test incorrectly used the subscriber's log file position as the starting offset when reading the publisher's log. As a result, the test failed to find the expected log message in the publisher's log and erroneously reported a failure. This commit fixes the test to use the publisher's own log file position when reading the publisher's log. Also, to avoid similar confusion in the future, this commit splits the single $log_location variable into $log_location_pub and $log_location_sub, clearly distinguishing publisher and subscriber log positions. Backpatched to v15, where commit 5f13999aa11 introduced the test. Per buildfarm member sungazer. This issue was reported and diagnosed by Alexander Lakhin. Reported-by: Alexander Lakhin <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/221232596fc6a26daffa64c294604f4f8507b95c Modified Files -------------- src/test/subscription/t/001_rep_changes.pl | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Fix logical replication TAP test to read publisher log correctly @ 2026-02-04 15:49 Fujii Masao <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Fujii Masao @ 2026-02-04 15:49 UTC (permalink / raw) To: [email protected] Fix logical replication TAP test to read publisher log correctly. Commit 5f13999aa11 added a TAP test for GUC settings passed via the CONNECTION string in logical replication, but the buildfarm member sungazer reported test failures. The test incorrectly used the subscriber's log file position as the starting offset when reading the publisher's log. As a result, the test failed to find the expected log message in the publisher's log and erroneously reported a failure. This commit fixes the test to use the publisher's own log file position when reading the publisher's log. Also, to avoid similar confusion in the future, this commit splits the single $log_location variable into $log_location_pub and $log_location_sub, clearly distinguishing publisher and subscriber log positions. Backpatched to v15, where commit 5f13999aa11 introduced the test. Per buildfarm member sungazer. This issue was reported and diagnosed by Alexander Lakhin. Reported-by: Alexander Lakhin <[email protected]> Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d242881bfad12dbbbc8effd418d25ef1367b372b Modified Files -------------- src/test/subscription/t/001_rep_changes.pl | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-02-04 15:49 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-02-04 15:48 pgsql: Fix logical replication TAP test to read publisher log correctly Fujii Masao <[email protected]> 2026-02-04 15:48 pgsql: Fix logical replication TAP test to read publisher log correctly Fujii Masao <[email protected]> 2026-02-04 15:48 pgsql: Fix logical replication TAP test to read publisher log correctly Fujii Masao <[email protected]> 2026-02-04 15:49 pgsql: Fix logical replication TAP test to read publisher log correctly Fujii Masao <[email protected]> 2026-02-04 15:49 pgsql: Fix logical replication TAP test to read publisher log correctly Fujii Masao <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox