public inbox for [email protected]  
help / color / mirror / Atom feed
From: Thomas Munro <[email protected]>
To: [email protected]
Subject: pgsql: Code coverage for most pg_mblen* calls.
Date: Mon, 09 Feb 2026 00:07:46 +0000
Message-ID: <[email protected]> (raw)

Code coverage for most pg_mblen* calls.

A security patch changed them today, so close the coverage gap now.
Test that buffer overrun is avoided when pg_mblen*() requires more
than the number of bytes remaining.

This does not cover the calls in dict_thesaurus.c or in dict_synonym.c.
That code is straightforward.  To change that code's input, one must
have access to modify installed OS files, so low-privilege users are not
a threat.  Testing this would likewise require changing installed
share/postgresql/tsearch_data, which was enough of an obstacle to not
bother.

Security: CVE-2026-2006
Backpatch-through: 14
Co-authored-by: Thomas Munro <[email protected]>
Co-authored-by: Noah Misch <[email protected]>
Reviewed-by: Heikki Linnakangas <[email protected]>

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4c08960d97e950b00a4f6bf255d5409da98c6032

Modified Files
--------------
contrib/pg_trgm/Makefile                    |   2 +-
contrib/pg_trgm/data/trgm_utf8.data         |  50 ++++
contrib/pg_trgm/expected/pg_utf8_trgm.out   |   8 +
contrib/pg_trgm/expected/pg_utf8_trgm_1.out |   3 +
contrib/pg_trgm/meson.build                 |   1 +
contrib/pg_trgm/sql/pg_utf8_trgm.sql        |   9 +
src/backend/utils/adt/arrayfuncs.c          |   6 +
src/test/regress/expected/encoding.out      | 401 ++++++++++++++++++++++++++++
src/test/regress/expected/encoding_1.out    |   4 +
src/test/regress/expected/euc_kr.out        |  16 ++
src/test/regress/expected/euc_kr_1.out      |   6 +
src/test/regress/parallel_schedule          |   2 +-
src/test/regress/regress.c                  | 139 ++++++++++
src/test/regress/sql/encoding.sql           | 228 ++++++++++++++++
src/test/regress/sql/euc_kr.sql             |  12 +
15 files changed, 885 insertions(+), 2 deletions(-)



view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Code coverage for most pg_mblen* calls.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox