public inbox for [email protected]
help / color / mirror / Atom feedFrom: Heikki Linnakangas <[email protected]>
To: [email protected]
Subject: pgsql: cleanup: Deadlock checker is no longer called from signal handle
Date: Mon, 09 Feb 2026 18:26:35 +0000
Message-ID: <[email protected]> (raw)
cleanup: Deadlock checker is no longer called from signal handler
Clean up a few leftovers from when the deadlock checker was called
from signal handler. We stopped doing that in commit 6753333f55, in
year 2015.
- CheckDeadLock can return a return value directly to the caller,
there's no need to use a global variable for that.
- Remove outdated comments that claimed that CheckDeadLock "signals
ProcSleep".
- It should be OK to ereport() from DeadLockCheck now. I considered
getting rid of InitDeadLockChecking() and moving the workspace
allocations into DeadLockCheck, but it's still good to avoid doing
the allocations while we're holding all the partition locks. So just
update the comment to give that as the reason we do the allocations
up front.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/73d60ac385a93684f68297ae0ccb8f75bc6f23e1
Modified Files
--------------
src/backend/storage/lmgr/deadlock.c | 10 ++++------
src/backend/storage/lmgr/proc.c | 28 ++++++++++++++++------------
2 files changed, 20 insertions(+), 18 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: cleanup: Deadlock checker is no longer called from signal handle
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox