public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Fix test_valid_server_encoding helper function.
6+ messages / 1 participants
[nested] [flat]
* pgsql: Fix test_valid_server_encoding helper function.
@ 2026-02-17 04:06 Thomas Munro <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2026-02-17 04:06 UTC (permalink / raw)
To: [email protected]
Fix test_valid_server_encoding helper function.
Commit c67bef3f325 introduced this test helper function for use by
src/test/regress/sql/encoding.sql, but its logic was incorrect. It
confused an encoding ID for a boolean so it gave the wrong results for
some inputs, and also forgot the usual return macro. The mistake didn't
affect values actually used in the test, so there is no change in
behavior.
Also drop it and another missed function at the end of the test, for
consistency.
Backpatch-through: 14
Author: Zsolt Parragi <[email protected]>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bd626ef093b2e5f279285a344c8ac53d67cdfd76
Modified Files
--------------
src/test/regress/expected/encoding.out | 2 ++
src/test/regress/regress.c | 2 +-
src/test/regress/sql/encoding.sql | 2 ++
3 files changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix test_valid_server_encoding helper function.
@ 2026-02-17 04:06 Thomas Munro <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2026-02-17 04:06 UTC (permalink / raw)
To: [email protected]
Fix test_valid_server_encoding helper function.
Commit c67bef3f325 introduced this test helper function for use by
src/test/regress/sql/encoding.sql, but its logic was incorrect. It
confused an encoding ID for a boolean so it gave the wrong results for
some inputs, and also forgot the usual return macro. The mistake didn't
affect values actually used in the test, so there is no change in
behavior.
Also drop it and another missed function at the end of the test, for
consistency.
Backpatch-through: 14
Author: Zsolt Parragi <[email protected]>
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ccc9be800dddf1662aa25aa4ee27aa71965b3fa9
Modified Files
--------------
src/test/regress/expected/encoding.out | 2 ++
src/test/regress/regress.c | 2 +-
src/test/regress/sql/encoding.sql | 2 ++
3 files changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix test_valid_server_encoding helper function.
@ 2026-02-17 04:06 Thomas Munro <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2026-02-17 04:06 UTC (permalink / raw)
To: [email protected]
Fix test_valid_server_encoding helper function.
Commit c67bef3f325 introduced this test helper function for use by
src/test/regress/sql/encoding.sql, but its logic was incorrect. It
confused an encoding ID for a boolean so it gave the wrong results for
some inputs, and also forgot the usual return macro. The mistake didn't
affect values actually used in the test, so there is no change in
behavior.
Also drop it and another missed function at the end of the test, for
consistency.
Backpatch-through: 14
Author: Zsolt Parragi <[email protected]>
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c33d67fd18edec3000be0e5d12096d983e0eced5
Modified Files
--------------
src/test/regress/expected/encoding.out | 2 ++
src/test/regress/regress.c | 2 +-
src/test/regress/sql/encoding.sql | 2 ++
3 files changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix test_valid_server_encoding helper function.
@ 2026-02-17 04:06 Thomas Munro <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2026-02-17 04:06 UTC (permalink / raw)
To: [email protected]
Fix test_valid_server_encoding helper function.
Commit c67bef3f325 introduced this test helper function for use by
src/test/regress/sql/encoding.sql, but its logic was incorrect. It
confused an encoding ID for a boolean so it gave the wrong results for
some inputs, and also forgot the usual return macro. The mistake didn't
affect values actually used in the test, so there is no change in
behavior.
Also drop it and another missed function at the end of the test, for
consistency.
Backpatch-through: 14
Author: Zsolt Parragi <[email protected]>
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cdf060dd9bbbd23339ee4ebc3077446fd9453bdb
Modified Files
--------------
src/test/regress/expected/encoding.out | 2 ++
src/test/regress/regress.c | 2 +-
src/test/regress/sql/encoding.sql | 2 ++
3 files changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix test_valid_server_encoding helper function.
@ 2026-02-17 04:07 Thomas Munro <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2026-02-17 04:07 UTC (permalink / raw)
To: [email protected]
Fix test_valid_server_encoding helper function.
Commit c67bef3f325 introduced this test helper function for use by
src/test/regress/sql/encoding.sql, but its logic was incorrect. It
confused an encoding ID for a boolean so it gave the wrong results for
some inputs, and also forgot the usual return macro. The mistake didn't
affect values actually used in the test, so there is no change in
behavior.
Also drop it and another missed function at the end of the test, for
consistency.
Backpatch-through: 14
Author: Zsolt Parragi <[email protected]>
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/e3bfa4f589a8a7127824f48a5892166ae7ac0e24
Modified Files
--------------
src/test/regress/expected/encoding.out | 2 ++
src/test/regress/regress.c | 2 +-
src/test/regress/sql/encoding.sql | 2 ++
3 files changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Fix test_valid_server_encoding helper function.
@ 2026-02-17 04:07 Thomas Munro <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Munro @ 2026-02-17 04:07 UTC (permalink / raw)
To: [email protected]
Fix test_valid_server_encoding helper function.
Commit c67bef3f325 introduced this test helper function for use by
src/test/regress/sql/encoding.sql, but its logic was incorrect. It
confused an encoding ID for a boolean so it gave the wrong results for
some inputs, and also forgot the usual return macro. The mistake didn't
affect values actually used in the test, so there is no change in
behavior.
Also drop it and another missed function at the end of the test, for
consistency.
Backpatch-through: 14
Author: Zsolt Parragi <[email protected]>
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/88fec079f13dae07a252339a74ed070284e94a20
Modified Files
--------------
src/test/regress/input/encoding.source | 2 ++
src/test/regress/output/encoding.source | 2 ++
src/test/regress/regress.c | 2 +-
3 files changed, 5 insertions(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-02-17 04:07 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-17 04:06 pgsql: Fix test_valid_server_encoding helper function. Thomas Munro <[email protected]>
2026-02-17 04:06 pgsql: Fix test_valid_server_encoding helper function. Thomas Munro <[email protected]>
2026-02-17 04:06 pgsql: Fix test_valid_server_encoding helper function. Thomas Munro <[email protected]>
2026-02-17 04:06 pgsql: Fix test_valid_server_encoding helper function. Thomas Munro <[email protected]>
2026-02-17 04:07 pgsql: Fix test_valid_server_encoding helper function. Thomas Munro <[email protected]>
2026-02-17 04:07 pgsql: Fix test_valid_server_encoding helper function. Thomas Munro <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox