public inbox for [email protected]
help / color / mirror / Atom feedFrom: Heikki Linnakangas <[email protected]>
To: [email protected]
Subject: pgsql: Use standard die() handler for SIGTERM in bgworkers
Date: Wed, 18 Feb 2026 18:07:37 +0000
Message-ID: <[email protected]> (raw)
Use standard die() handler for SIGTERM in bgworkers
The previous default bgworker_die() signal would exit with elog(FATAL)
directly from the signal handler. That could cause deadlocks or
crashes if the signal handler runs while we're e.g holding a spinlock
or in the middle of a memory allocation.
All the built-in background workers overrode that to use the normal
die() handler and CHECK_FOR_INTERRUPTS(). Let's make that the default
for all background workers. Some extensions relying on the old
behavior might need to adapt, but the new default is much safer and is
the right thing to do for most background workers.
Reviewed-by: Nathan Bossart <[email protected]>
Reviewed-by: Kirill Reshke <[email protected]>
Discussion: https://www.postgresql.org/message-id/[email protected]
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d62dca3b297413a11a594c9675f2fb22e931d01b
Modified Files
--------------
doc/src/sgml/bgworker.sgml | 10 ++++++++++
src/backend/access/transam/parallel.c | 1 -
src/backend/postmaster/bgworker.c | 16 +---------------
src/backend/replication/logical/applyparallelworker.c | 1 -
src/backend/replication/logical/launcher.c | 1 -
src/backend/replication/logical/worker.c | 1 -
src/test/modules/test_shm_mq/worker.c | 8 +-------
7 files changed, 12 insertions(+), 26 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Use standard die() handler for SIGTERM in bgworkers
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox