public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: [email protected]
Subject: pgsql: Remove SpinLockFree() and S_LOCK_FREE().
Date: Thu, 19 Feb 2026 22:20:28 +0000
Message-ID: <[email protected]> (raw)

Remove SpinLockFree() and S_LOCK_FREE().

S_LOCK_FREE() is used by the test program in s_lock.c, but nobody
has voiced concerns about losing some coverage there.
SpinLockFree() appears to have been unused since it was introduced
by commit 499abb0c0f.  There was agreement to remove these in 2020,
but it never happened.  Since we still have agreement for removal
in 2026, let's do that now.

Reviewed-by: Fabrízio de Royes Mello <[email protected]>
Reviewed-by: Andres Freund <[email protected]>
Discussion: https://postgr.es/m/aZX2oUcKf7IzHnnK%40nathan
Discussion: https://postgr.es/m/20200608225338.m5zho424w6lpwb2d%40alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ba401828c194c17031a6a2dedd97bc0defd80d4b

Modified Files
--------------
src/backend/storage/lmgr/s_lock.c | 24 ------------------------
src/include/storage/s_lock.h      |  8 --------
src/include/storage/spin.h        |  6 ------
3 files changed, 38 deletions(-)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgsql: Remove SpinLockFree() and S_LOCK_FREE().
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox