public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: [email protected]
Subject: pgsql: Avoid including worker_internal.h in pgstat.h.
Date: Fri, 20 Feb 2026 04:01:48 +0000
Message-ID: <[email protected]> (raw)
Avoid including worker_internal.h in pgstat.h.
pgstat.h is a widely included header. Including worker_internal.h there is
unnecessary and creates tight coupling. By refactoring
pgstat_report_subscription_error() to fetch the required
LogicalRepWorkerType internally rather than receiving it as an argument,
we can eliminate the need for the internal header.
Reported-by: Andres Freund <[email protected]>
Author: Nisha Moond <[email protected]>
Reviewed-by: vignesh C <[email protected]>
Reviewed-by: Amit Kapila <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9842e8aca096d9b988a3ae924cdf4aa7e1bb2ea2
Modified Files
--------------
src/backend/commands/functioncmds.c | 1 +
src/backend/replication/logical/sequencesync.c | 3 +--
src/backend/replication/logical/tablesync.c | 3 +--
src/backend/replication/logical/worker.c | 6 ++----
src/backend/storage/ipc/procsignal.c | 1 +
src/backend/utils/activity/pgstat_subscription.c | 3 ++-
src/include/pgstat.h | 4 +---
src/include/replication/worker_internal.h | 7 +++++++
src/test/modules/test_custom_stats/test_custom_var_stats.c | 1 +
9 files changed, 17 insertions(+), 12 deletions(-)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: pgsql: Avoid including worker_internal.h in pgstat.h.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox